fix: disable threaded console when we use fork #8121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is similar to ocaml#8100 for the threaded console. The reason we're doing that is to avoid threads when fork is involved. Signed-off-by: Etienne Millon <me@emillon.org>
emillon
force-pushed
the
fix-threaded-console-disable
branch
from
c1f8fdc
to
a53cb5e
Compare
This was referenced Jul 6, 2023
Closed
rgrinberg
approved these changes
Jul 6, 2023
emillon
added a commit
to emillon/dune
that referenced
this pull request
Jul 6, 2023
This is similar to ocaml#8100 for the threaded console. The reason we're doing that is to avoid threads when fork is involved. Signed-off-by: Etienne Millon <me@emillon.org>
emillon
added a commit
to emillon/dune
that referenced
this pull request
Jul 6, 2023
This is similar to ocaml#8100 for the threaded console. The reason we're doing that is to avoid threads when fork is involved. Signed-off-by: Etienne Millon <me@emillon.org>
emillon
added a commit
that referenced
this pull request
Jul 6, 2023
emillon
added a commit
to emillon/opam-repository
that referenced
this pull request
Jul 6, 2023
CHANGES: - Disable background operations and threaded console on MacOS and other Unixes where we rely on fork. (ocaml/dune#8100, ocaml/dune#8121, fixes ocaml/dune#8083, @rgrinberg, @emillon) - Initialize async IO thread lazily. (ocaml/dune#8122, @emillon)
nberth
pushed a commit
to nberth/opam-repository
that referenced
this pull request
Jun 18, 2024
CHANGES: - Disable background operations and threaded console on MacOS and other Unixes where we rely on fork. (ocaml/dune#8100, ocaml/dune#8121, fixes ocaml/dune#8083, @rgrinberg, @emillon) - Initialize async IO thread lazily. (ocaml/dune#8122, @emillon)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is similar to #8100 for the threaded console. The reason we're doing that is to avoid threads when fork is involved.