Allow to set the library path at configure time #575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
This allow to drop the dependency on ocamlfind
rgrinberg
requested changes
Mar 5, 2018
jbuilder.opam
Outdated
| @@ -6,17 +6,9 @@ bug-reports: "https://github.com/ocaml/dune/issues" | |||
| dev-repo: "https://github.com/ocaml/dune.git" | |||
| license: "Apache-2.0" | |||
| build: [ | |||
| ["ocaml" "configure.ml" "--library-path" lib] | |||
There was a problem hiding this comment.
This is a typo? You mean libdir perhaps.
rgrinberg
approved these changes
Mar 6, 2018
andreypopp
added a commit
to esy-ocaml/esy-opam-override
that referenced
this pull request
Mar 20, 2018
We override build commands to skip the configure step which memoizes the library path during the compilation of the jbuilder itself. With opam it's ok to memoize but not with esy as we reconfigure libpath dynamically. See ocaml/dune#575 for details.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way, jbuilder never ends up calling ocamlfind while building opam packages, so we can drop the dependency on ocamlfind.