Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All Recursive Aliases are broken in vendored directories #10144

Open
rgrinberg opened this issue Feb 26, 2024 · 1 comment
Open

All Recursive Aliases are broken in vendored directories #10144

rgrinberg opened this issue Feb 26, 2024 · 1 comment
Labels

Comments

@rgrinberg
Copy link
Member

We never traverse recursive aliases in directories marked with (vendored_dirs ..). I suppose this was done to disable the tests there, but the current behavior is way too aggressive and unintuitive.

cc @snowleopard

@rgrinberg rgrinberg added the bug label Feb 26, 2024
@rgrinberg rgrinberg added requires-team-discussion This topic requires a team discussion and removed requires-team-discussion This topic requires a team discussion labels Mar 5, 2024
@rgrinberg
Copy link
Member Author

This was discussed in the team meeting:

  • The fact that (alias_rec ..) is completely broken in vendored directories needs to be fixed separately
  • There was general agreement that vendored directories should have their own alias namespace
  • There should be a way for some aliases to recurse to vendored directories (e.g. @check)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant