Skip to content

break-struct for sig fix #2709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

EmileTrotignon
Copy link
Collaborator

There was a bug in my #2682 PR to apply break-struct=natural to sig ... end.

This fixes that bug. The bug was that the box structure did not put the end on a new line:

module type T = sig
  type a
  type b end

The implem is a bit hacking, but I tried modifying the box structure to do something cleaner, but it was very hard to do without making diffs all over the place. I can't just copy the struct ... end boxes because of the following:

module S : sig
  type a
  type b
end = struct
  type a = int
  type b = string
end

The code for struct ... end simply handles less cases.

@EmileTrotignon EmileTrotignon requested a review from Julow May 2, 2025 15:51
@EmileTrotignon EmileTrotignon added the no changelog set this to bypass the CI check for changelog entries label May 5, 2025
@EmileTrotignon
Copy link
Collaborator Author

EmileTrotignon commented May 5, 2025

No changelog because the bug was introduced in #2682 which is still unreleased.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Kind/Bug ❌ no changelog set this to bypass the CI check for changelog entries
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant