Represent 'let f _ = function' in the CST #2596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes various inconsistencies and will help write parens rules for functions.
Currently, the CST represents the arguments of 'let f _ =' in a way that
is incompatible with the changed function representation from OCaml 5.2.
These two are represented the same way in the CST:
let f _ = function ...
let f _ = (function ...)
To fix this problem, the representation for let bindings bodies is
changed to 'function_body', matching the 5.2 representation.
This is still work in progress, Ast rules need to be tweaked, a comment
is dropped and some formattings are broken.
And reuse code between 'Lb' and 'Pexp_let' Ast rules.
|
This fixes a critical bug in #2544 and fixes bad indentation and unwanted parentheses in let bindings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the CST represents the arguments of 'let f _ =' in a way that
is incompatible with the changed function representation from OCaml 5.2.
These two were represented the same way in the CST:
To fix this problem, the representation for let bindings bodies is
changed to 'function_body', matching the 5.2 representation.
The
ctxused while formatting let bindings is changed and this caused a large number of changes in the code and removed a few unnecessary parentheses in the output.