Stricter AST checks #2557
Merged
Stricter AST checks #2557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This use the extended AST normalization for docstrings within the std AST. This ensures that repl phrases are handled correctly and removes some code.
The AST check was previously trigerring if both the std AST and the extended AST were different. The std AST is intended to be the most trustworthy and is intended to catch changes in the code that the extended AST couldn't.
Julow
added
the
no changelog
This was referenced Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AST check was previously trigerring if both the std AST and the
extended AST were different. This is not the intended behavior.
The first commit changes the normalization of code blocks in docstrings to correctly handle repl phrases. This fixes an AST error that was hidden by the previous check.