Skip to content

Commit dea2172

Browse files
fix comments
1 parent 4a92203 commit dea2172

File tree

8 files changed

+43
-9
lines changed

8 files changed

+43
-9
lines changed

lib/Fmt_ast.ml

Lines changed: 16 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -2887,11 +2887,12 @@ and fmt_apply c ~e1N1 ~parens ~pro ~ctx ~e0 ~pexp_loc ~pexp_attributes
28872887
| Pexp_beginend
28882888
( { pexp_desc= Pexp_function (largs, ltyp, lbody)
28892889
; pexp_attributes= attrs_beginend
2890+
; pexp_loc
28902891
; _ } as e_func ) ->
28912892
fmt_apply_last_arg_function c ~last_arg ~lbody ~parens ~intro_epi
28922893
~pexp_loc ~lbl ~ctx ~largs ~has_attr ~expr_epi ~fmt_atrs ~ltyp ~e0
28932894
~fmt_args_grouped ~args_before ~wrap
2894-
~beginend:(Some (attrs_beginend, Exp e_func))
2895+
~beginend:(Some (attrs_beginend, pexp_loc, Exp e_func))
28952896
| _ ->
28962897
let fmt_atrs = fmt_attributes c ~pre:(Break (1, -2)) pexp_attributes in
28972898
let force =
@@ -2930,18 +2931,24 @@ and fmt_apply_last_arg_function c ~last_arg ~lbody ~parens ~intro_epi
29302931
if Location.is_single_line pexp_loc c.conf.fmt_opts.margin.v then Fit
29312932
else Break
29322933
in
2933-
let break_end =
2934-
let indent =
2935-
match (largs, lbody) with [], Pfunction_cases _ -> 0 | _ -> -2
2936-
in
2937-
break 1000 indent
2938-
in
29392934
let pro, inner_ctx, end_ =
29402935
match beginend with
29412936
| None -> (noop, inner_ctx, noop)
2942-
| Some (attrs, inner_ctx) ->
2937+
| Some (attrs, pexp_loc, inner_ctx) ->
2938+
let break_end =
2939+
let indent =
2940+
match (largs, lbody) with
2941+
| [], Pfunction_cases _ -> 0
2942+
| _ -> -2
2943+
in
2944+
break 1000 indent
2945+
in
2946+
let cmts_begin = Cmts.fmt_before c pexp_loc in
2947+
let cmts_end = Cmts.fmt_after c pexp_loc in
29432948
let fmt_atrs = fmt_attributes c ~pre:Space attrs in
2944-
(str "begin" $ fmt_atrs $ str " ", inner_ctx, break_end $ str "end")
2949+
( str "begin" $ fmt_atrs $ str " " $ cmts_begin
2950+
, inner_ctx
2951+
, cmts_end $ break_end $ str "end" )
29452952
in
29462953
(* bookmark *)
29472954
fmt_function ~pro ~last_arg:true ~force_closing_paren ~ctx:inner_ctx

test/passing/refs.default/exp_grouping-parens.ml.ref

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -576,3 +576,5 @@ let _ =
576576
| _ -> aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa
577577
| _ ->
578578
bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb)
579+
580+
let a = fffffff (* a *) (fun () -> a) (* cmt *)

test/passing/refs.default/exp_grouping.ml.ref

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -667,3 +667,8 @@ let _ =
667667
| _ -> aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa
668668
| _ ->
669669
bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb)
670+
671+
let a =
672+
fffffff begin (* a *) fun () -> a
673+
(* cmt *)
674+
end

test/passing/refs.janestreet/exp_grouping-parens.ml.ref

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -654,3 +654,5 @@ let _ =
654654
| _ -> aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa
655655
| _ -> bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb)
656656
;;
657+
658+
let a = fffffff (* a *) (fun () -> a) (* cmt *)

test/passing/refs.janestreet/exp_grouping.ml.ref

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -754,3 +754,9 @@ let _ =
754754
| _ -> aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa
755755
| _ -> bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb)
756756
;;
757+
758+
let a =
759+
fffffff begin (* a *) fun () -> a
760+
(* cmt *)
761+
end
762+
;;

test/passing/refs.ocamlformat/exp_grouping-parens.ml.ref

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -585,3 +585,5 @@ let _ =
585585
aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa
586586
| _ ->
587587
bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb )
588+
589+
let a = fffffff (* a *) (fun () -> a) (* cmt *)

test/passing/refs.ocamlformat/exp_grouping.ml.ref

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -683,3 +683,8 @@ let _ =
683683
aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa
684684
| _ ->
685685
bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb )
686+
687+
let a =
688+
fffffff begin (* a *) fun () -> a
689+
(* cmt *)
690+
end

test/passing/tests/exp_grouping.ml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -534,3 +534,8 @@ let _ =
534534
match x with
535535
| _ -> aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa
536536
| _ -> bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb)
537+
538+
let a =
539+
fffffff begin (* a *) fun () -> a
540+
(* cmt *)
541+
end

0 commit comments

Comments
 (0)