consider case when a labeled tuple element has an infix expression so that it is wrapped in parentheses

only wrap with parentheses if the tuple element has a label, instead of wrapping any infix expression bc of some other tuple element label

add cram test

adding test case to the end of labeled_tuples.ml

Author: cod1r

lib/Fmt_ast.ml

@@ -2219,6 +2219,12 @@ and fmt_expression c ?(box = true) ?(pro = noop) ?eol ?parens
             ; _ }
           when not (Std_longident.is_infix id) ->
             has_attr && parens
+        | Exp {pexp_desc= Pexp_tuple tuples; _}
+          when List.exists tuples ~f:(fun tuple ->
+                   match tuple with
+                   | Lte_simple {lte_label= Some _; lte_elt} -> phys_equal lte_elt exp
+                   | _ -> false ) ->
+            true
         | Lb {pvb_body= Pfunction_body body; _} when phys_equal body exp ->
             has_attr && parens
         | _ -> has_attr && not parens

test/passing/refs.ahrefs/labeled_tuples.ml.ref

@@ -629,3 +629,11 @@ let
     (* after y *),
     (* bz *)
     ~z:(*zv*) 0 (*end*) )
+
+(** With infix expressions **)
+let labeled_tuple () = ~x:1, ~y:(1 + 2)
+
+let labeled_tuple2 () = 1 + 2, ~y:1
+let labeled_tuple3 () = 1 + 2, ~y:(1 + 2)
+let ~x, .. = labeled_tuple ()
+let ~y, .. = labeled_tuple2 ()

test/passing/refs.default/labeled_tuples.ml.ref

@@ -568,3 +568,11 @@ let
     (* after y *),
     (* bz *)
     ~z:(*zv*) 0 (*end*) )
+
+(** With infix expressions **)
+let labeled_tuple () = (~x:1, ~y:(1 + 2))
+
+let labeled_tuple2 () = (1 + 2, ~y:1)
+let labeled_tuple3 () = (1 + 2, ~y:(1 + 2))
+let ~x, .. = labeled_tuple ()
+let ~y, .. = labeled_tuple2 ()

test/passing/refs.janestreet/labeled_tuples.ml.ref

@@ -628,3 +628,11 @@ let
   , (* bz *)
     ~z:(*zv*) 0 (*end*) )
 ;;
+
+(** With infix expressions **)
+let labeled_tuple () = ~x:1, ~y:(1 + 2)
+
+let labeled_tuple2 () = 1 + 2, ~y:1
+let labeled_tuple3 () = 1 + 2, ~y:(1 + 2)
+let ~x, .. = labeled_tuple ()
+let ~y, .. = labeled_tuple2 ()

test/passing/refs.ocamlformat/labeled_tuples.ml.ref

@@ -634,3 +634,14 @@ let
     (* after y *)
   , (* bz *)
     ~z:(*zv*) 0 (*end*) )
+
+(** With infix expressions **)
+let labeled_tuple () = (~x:1, ~y:(1 + 2))
+
+let labeled_tuple2 () = (1 + 2, ~y:1)
+
+let labeled_tuple3 () = (1 + 2, ~y:(1 + 2))
+
+let ~x, .. = labeled_tuple ()
+
+let ~y, .. = labeled_tuple2 ()

test/passing/tests/labeled_tuples.ml

@@ -657,3 +657,10 @@ let (*before*) ~(x (*l-ty*):int (*after-ty*)) (*after x*),
     (*before y*) ~y (* after y *), (* bz *) ~z:(*zv*)0 (*end*) =
   (*before*) ~(x (*l-ty*):int (*after-ty*)) (*after x*),
     (*before y*) ~y (* after y *), (* bz *)~z:(*zv*)0 (*end*)
+
+(** With infix expressions **)
+let labeled_tuple () = (~x:1, ~y:(1 + 2))
+let labeled_tuple2 () = (1 + 2, ~y:1)
+let labeled_tuple3 () = (1 + 2, ~y:(1 + 2))
+let ~x, .. = labeled_tuple ()
+let ~y, .. = labeled_tuple2 ()