Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for upcoming OCaml 4.10 ? #85

Closed
gasche opened this issue Nov 1, 2019 · 9 comments
Closed

support for upcoming OCaml 4.10 ? #85

gasche opened this issue Nov 1, 2019 · 9 comments

Comments

@gasche
Copy link

gasche commented Nov 1, 2019

As of this week, the versions of ocaml-migrate-parsetree available on opam are incompatible (or at least marked incompatible) with the upcoming 4.10 release. Would it be possible to ensure compatibility with the current 4.10 branch, and have a version available on opam that enables it, or at least a clear reference to pin? This would unlock testing of user code when we make our first beta releases (expected in a few weeks).

(We do not expect to change the parsetree now that the release branch has been created, but there is a small chance that it could happen, for example thanks to m-o-p dogfooding the changes and suggesting fixes. I still think having an opam release is nicer than pinning, especially for people doing release Q/A with opam testing tools.)

Thanks!

@gasche
Copy link
Author

gasche commented Nov 1, 2019

@ghost
Copy link

ghost commented Nov 4, 2019

Let me have a look at this. What's the recommended way of installing a non-released compiler nowadays?

@gasche
Copy link
Author

gasche commented Nov 4, 2019

It's documented in the compiler's HACKING.adoc file:

opam switch create . --empty
opam install .

@ghost
Copy link

ghost commented Nov 5, 2019

The magic numbers for the AST ends with 26 in 4.09 and with 25 in 4.10. That looks ood

@gasche
Copy link
Author

gasche commented Nov 5, 2019

It may be very well be that the magic numbers have not been updated in 4.10 yet. Let me check with @damiendoligez, thanks for the feedback!

@gasche
Copy link
Author

gasche commented Nov 5, 2019

Yes! @Octachron volunteered to update magic numbers in 4.10 and trunk, should be done shortly.

@Octachron
Copy link

The magic numbers have updated (and end with 27), on both 4.10 and trunk (to avoid trunk trailing with the magic number of 4.08).

@ghost
Copy link

ghost commented Nov 5, 2019

I updated ocaml-migrate-parsetree to 4.10. Release is pending on this: tarides/dune-release#174

@ghost
Copy link

ghost commented Nov 14, 2019

it's now released: ocaml/opam-repository#15280

@ghost ghost closed this as completed Nov 14, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants