CI: Add native and bytecode workflows using MSVC #399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmid
reviewed
Mar 15, 2024
There was a problem hiding this comment.
Thanks again for this 🙏 MSVC has been merged so we should get this nice PR rolling! 😃
A little fiddling is required I believe:
- This should target
ocaml/ocamltrunk rather thandra27/ocamlIIUC - The workflows should be renamed to
msvc-530-trunk.ymlandmsvc-530-trunk-bytecode.ymlto fit into the existing naming scheme
A few questions:
- Is the source code install of
duneandqcheckstill required, or can we go with opam now? - I suppose this is not set up to easily test PRs and feature branches? (just asking, Cygwin + multicoretests-ci doesn't support this ATM either)
Avoid running QCheck tests as part of a `dune runtest` even if it is vendored
Add a native workflow and a bytecode one using MSVC Run the bytecode-only in two parts, like Cygwin Use the current bleeding edge versions of dune and QCheck as they recently merged fixes that are relevant for these workflows Add badges for those two new workflows
|
CI summary for 9ce6e3e:
(Note: CI on this PR is still targeting Out of 37 workflows 6 failed all with genuine issues |
|
CI summary for merge to
Out of 38 workflows 5 failed all with genuine issues |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a native workflow and a bytecode one using MSVC
Run the bytecode-only in two parts, like Cygwin, since preliminary results seem to suggest the test suite will require more than 6 hours to complete
Use the current bleeding edge versions of dune and QCheck as they recently merged fixes that are relevant for these workflows
Add badges for those two new workflows, on a separate line, as they aren’t really on
trunk