Skip to content

Add support for extensions in module types #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 10, 2023

Conversation

goldfirere
Copy link
Contributor

This doesn't actually support strengthening, but just lays the groundwork for doing so. For strengthening support, wait for the next PR, coming up soon.

@goldfirere goldfirere force-pushed the rae/module-type-extensions branch 2 times, most recently from f228bce to 170f9a9 Compare March 9, 2023 13:05
@goldfirere goldfirere mentioned this pull request Mar 9, 2023
Copy link
Contributor

@antalsz antalsz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goldfirere goldfirere force-pushed the rae/module-type-extensions branch from 2144615 to f89b991 Compare March 10, 2023 13:19
@goldfirere goldfirere force-pushed the rae/extension-destructors branch from f091984 to 2f9d1a3 Compare March 10, 2023 14:09
@goldfirere goldfirere force-pushed the rae/module-type-extensions branch from e9e25bf to 9cd7dc1 Compare March 10, 2023 16:43
@goldfirere goldfirere changed the base branch from rae/extension-destructors to main March 10, 2023 20:01
@goldfirere goldfirere merged commit 163c4b9 into main Mar 10, 2023
ncik-roberts pushed a commit to ncik-roberts/ocaml-jst that referenced this pull request Mar 13, 2023
ncik-roberts pushed a commit to ncik-roberts/ocaml-jst that referenced this pull request Mar 14, 2023
@goldfirere goldfirere deleted the rae/module-type-extensions branch March 21, 2023 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants