[lld] check disk space before writing to disk if using mmap #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshinwell
approved these changes
Feb 22, 2024
poechsel
added a commit
that referenced
this pull request
Apr 17, 2025
poechsel
added a commit
that referenced
this pull request
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If lld is asked to output the binary using mmap (which is the default), then lld fails with SIGBUS when running out of disk.
This is confusing for users - this PR checks that there's enough disk space before actually saving the file.
This might make LLD a bit slower.
Tested by building binaries locally and by manually making sure that sizes returned by
disk_spaceandfileSizehave the same unit and are consistent with
du -B 1anddf -B 1