Emit low-level location information for FDO: fix backtraces (1/2) #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshinwell
referenced
this pull request
in mshinwell/flambda-backend
May 17, 2021
poechsel
pushed a commit
to poechsel/flambda-backend
that referenced
this pull request
May 26, 2021
poechsel
pushed a commit
that referenced
this pull request
Jun 28, 2021
poechsel
pushed a commit
that referenced
this pull request
Jun 29, 2021
stedolan
added a commit
that referenced
this pull request
Feb 1, 2022
173842c Merge flambda-backend changes ed7eba2 Remove leading space from LINE. (#484) bd61170 Bump magic numbers (#5) c50c47d Add CI builds with local allocations enabled 1412792 Move local allocations support behind '-extension local' 6d8e42a Better tail call behaviour in caml_applyN c7dac3d Typemod: toplevel bindings escape even if no variables are bound 82d6c3e Several fixes for partial application and currying d05c70c Pprintast support for new local syntax e0e62fc Typecheck x |> f y as (f y x), not ((f y) x) d7e34ce Remove autogeneration of @ocaml.curry b9a0593 Port #493 0a872d9 Code review fixes from #491 6c168bb Remove local allocation counting 3c6e7f0 Code review fixes from #478 bb97207 Rename Lambda.apply_position a7cb650 Quieten Makefile when runtime dep files are not present c656dc9 Merge flambda-backend changes 11b5424 Avoid printing double spaces in function argument lists 7751faa Restore locations to Typedtree.{pat,let}_bound_idents_full e450b6c add build_ocaml_compiler.sexp 0403bb3 Revert PR 9895 to continue installing VERSION b3447db Ensure new local attributes are namespaced properly 7f213fc Allow empty functions again 8f22ad8 Bugfix: ensure local domain state is initialised 80f54dd Bugfix for Selectgen with regions e8133a1 Fix external-external signature inclusion 9840051 Bootstrap d879f23 Merge remote-tracking branch 'jane/local-reviewed' into local-merge 94454f5 Use Local_store for the local allocations ref 54a164c Create fewer regions, according to typechecking (#59) 1c2479b Merge flambda-backend changes ce34678 Fix printing of modes in return types 91f2281 Hook mode variable solving into Btype.snapshot/backtrack 54e4b09 Move Alloc_mode and Value_mode to Btype ff4611e Merge flambda-backend changes ce62e45 Ensure allocations are initialised, even dead ones 6b6ec5a Fix the alloc.ml test on 32-bit builds 81e9879 Merge flambda-backend changes 40a7f89 Update repo URL for ocaml-jst, and rename script. 0454ee7 Add some new locally-allocating primitives (#57) 8acdda1 Reset the local stack pointer in exception handlers (#56) 8dafa98 Improve typing for (||) and (&&) (#55) 8c64754 Fix make_check_all_arches (#54) b50cd45 Allow arguments to primitives to be local even in tail position (#53) cad125d Fix modes from or-patterns (#50) 4efdb72 Fix tailcalls tests with inlining (#52) 4a795cb Flambda support (#49) 74722cb Add [@ocaml.principal] and [@ocaml.noprincipal] attributes, and use in oo.mli 6d7d3b8 Ensure that functions are evaluated after their arguments (flambda-backend #353) 89bda6b Keep Sys.opaque_identity in Cmm and Mach (port upstream PR 9412) a39126a Fix tailcalls within regions (#48) 4ac4cfd Fix stdlib manpages build 3a95f5e Merge flambda-backend changes efe80c9 Add jane/pull-flambda-patches script fca94c4 Register allocations for Omitted parameter closures (#47) 103b139 Remove various FIXMEs (#46) 62ba2c1 Bootstrap a0062ad Allow local allocations for various primitives (#43) 7a2165e Allow primitives to be poly-moded (#43) 2af3f55 Fix a flaky test by refactoring TypePairs (ocaml/ocaml#10638) 58dd807 Bootstrap ee3be10 Fix modes in build_apply for partial applications fe73656 Tweak for evaluation order of labelled partial applications (#10653) 0527570 Fix caml_modify on local allocations (#40) e657e99 Relax modes for `as` patterns (#42) f815bf2 Add special mode handling for tuples in matches and let bindings (#38) 39f1211 Only take the upper bounds of modes associated with allocations (#37) aec6fde Interpret arrow types in "local positions" differently c4f3319 Bootstrap ff6fdad Add some missing regions 40d586d Bootstrap 66d8110 Switch to a system with 3 modes for values f2c5a85 Bugfix for Comballoc with local allocations. (#41) 83bcd09 Fix bug with root scanning during compaction (#39) 1b5ec83 Track modes in Lambda.lfunction and onwards (#33) f1e2e97 Port ocaml/ocaml#10728 56703cd Port ocaml/ocaml#10081 eb66785 Support local allocations in i386 and fix amd64 bug (#31) c936b19 Disallow local recursive non-functions (#30) c7a193a GC support for local allocations (#29) 8dd7270 Nonlocal fields (#28) e19a2f0 Bootstrap 694b9ac Add syntax to the parser for local allocations (#26) f183008 Lower initial stack size 918226f Allow local closure allocations (#27) 2552e7d Introduce mode variables (#25) bc41c99 Minor fixes for local allocations (#24) a2a4e60 Runtime and compiler support for more local allocations (#23) d030554 Typechecking for local allocations (#21) 9ee2332 Bugfix missing from #20 02c4cef Retain block-structured local regions until Mach. 86dbe1c amd64: Move stack realloc calls out-of-line 324d218 More typing modes and locking of environments a4080b8 Initial version of local allocation (unsafe) git-subtree-dir: ocaml git-subtree-split: 173842c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FDO profile collection relies on extra debug info in the executable.
Extra debug info is created by ocamlfdo tool and passed to
Emitphase in the compiler.Extra debug info was encoded as a
Debuginfo.itemand added todbgfield of a Linear instruction.The filename for this debug item was fabricated from the function symbol. This causes two problems.
The
dbgfield is used for emittingFDO info appears as an extra stack frame in the backtrace and in particular causes any tests that compare backtraces to fail.
.locdirectives.This mechanism is used by FDO to map raw binary addresses to the corresponding instructions in the Linear IR. However, not having the original source filename and line number makes it harder to use tools like perf and gdb that reuse the same mechanism.
This PR extends
Linear.instructionwith a new field dedicated to holding FDO location information. Then, the compiler emits .loc directives with FDO info, if available. The code for it is moved toemit.mlpfromocamlcfglibrary.This fixes 1 because the
dbgused in the frametables is no longer modified by FDO.