Fix untypeast/pprintast bug (backport upstream 13845) #3663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdelvecchio-jsc
requested changes
Mar 5, 2025
ccasin
force-pushed
the
untypeast-pprint-bug
branch
from
55fff3e to
f227150
Compare
@tdelvecchio-jsc Good question. It turns out that the I don't have time to debug it today - what I've done is to add a test demonstrating it's broken in the first commit. The second commit doesn't fix it, but at least we know it's not the cause. I propose merging this as is and fixing this another day. |
tdelvecchio-jsc
approved these changes
Mar 5, 2025
| pat, Some constr, modes | ||
| | _ -> pat, None, [] | ||
| in | ||
| Vb.mk ~loc ~attrs ?value_constraint ~modes pat (sub.expr sub vb.vb_expr) |
There was a problem hiding this comment.
This currently drops vb.pvb_modes. If you are fine with that since modes are broken anyways then that's fine, but wanted to point it out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tiny PR backports ocaml/ocaml#13845 to fix a bug in untypeast/pprintast.
It has already been reviewed upstream so low scrutiny is appropriate. The only question on our end is whether we need to do anything special about modes, and I think the answer is no because both
let x @ local = ...andlet (x @ local) = ...are valid syntax.Request review from @tdelvecchio-jsc