Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unboxed product array fixes #3346

Merged
merged 3 commits into from
Dec 10, 2024
Merged

Unboxed product array fixes #3346

merged 3 commits into from
Dec 10, 2024
+38 −7

Conversation

mshinwell
Copy link
Collaborator

This fixes a few small problems in #3068. The tests used to discover these will be merged as part of #3317.

@mshinwell
Fix indexing bug
162403e 
(cherry picked from commit ea64722)
@mshinwell
Fix error in array length divisor
8dd73f4 
(cherry picked from commit bf8b932)
@mshinwell
Fix array length
f49a464 
(cherry picked from commit c4e0cb6)
@mshinwell mshinwell added the flambda2 Prerequisite for, or part of, flambda2 label Dec 6, 2024
@mshinwell mshinwell requested a review from Ekdohibs December 6, 2024 15:02
@mshinwell mshinwell enabled auto-merge (squash) December 6, 2024 15:50
@mshinwell mshinwell merged commit 1378cda into ocaml-flambda:main Dec 10, 2024
19 checks passed
jvanburen pushed a commit that referenced this pull request Dec 10, 2024
@mshinwell @jvanburen
Unboxed product array fixes (#3346)
a934c52 
* Fix indexing bug

(cherry picked from commit ea64722)

* Fix error in array length divisor

(cherry picked from commit bf8b932)

* Fix array length

(cherry picked from commit c4e0cb6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ekdohibs Ekdohibs Ekdohibs approved these changes

Assignees
No one assigned
Labels
flambda2 Prerequisite for, or part of, flambda2 unboxed types
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mshinwell @Ekdohibs