Module inclusion check looks at module mode #3328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riaqn
added
typing
modes
goldfirere
reviewed
Nov 29, 2024
lpw25
reviewed
Nov 29, 2024
riaqn
force-pushed
the
modal-inclusion-check
branch
from
524e1c7 to
8c1d017
Compare
|
Had an offline discussion - we now distinguish between module type declaration vs module/value declaration, when performing inclusion check. Only the latter is affected by this PR. |
riaqn
force-pushed
the
modal-inclusion-check
branch
2 times, most recently
from
3b0a802 to
7b58880
Compare
lpw25
reviewed
Dec 13, 2024
riaqn
force-pushed
the
modal-inclusion-check
branch
from
c6bba38 to
f7d2871
Compare
riaqn
force-pushed
the
modal-inclusion-check
branch
from
c4ad48d to
33df433
Compare
|
This is ready for another look now - commits "correct semantics" and "address comments". |
lpw25
approved these changes
Dec 13, 2024
riaqn
force-pushed
the
modal-inclusion-check
branch
from
14e82df to
655a6eb
Compare
riaqn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Value description inclusion check now considers the mode of the modules, as opposed to looking at the value modalities only.
This PR is surprisingly simple, because modules are currently fixed to be legacy. When we support non-legacy modules in the future, we will have to pipe those data through.
Based on this PR, I will shortly make another PR that simplifies inferred modalities.