Disable inlining for effect functions that manipulate stacks #3231
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of the effect
continue
functions extract a stack pointer from the given continuation and hide it in an immediate.If we enter the GC between extracing the stack and calling
resume
, the stack will not be marked, leading to memory corruption.This situation can only occur due to re-ordering allocations after inlining, so we can work around this issue by disabling inlining.
Additionally,
Deep.try/match_with
andShallow.fiber
must not enter the GC betweenalloc_stack
andrunstack
for the same reason.A better fix would be to change the fiber layout to not rely on storing the stack/last_fiber pointers as immediates, or at least use a single primitive to implement atomic
continue
andalloc_and_runstack
operations.