-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Vec128 sort #2965
Add Vec128 sort #2965
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really sorry that, due to ICFP prep, ICFP, and the sprint, it took me so long to get to this. Various comments below. I'd also like to talk through the story about how this will work in the tree (want to avoid jsoo issues like we had with float32), but perhaps we can talk through that when we meet tomorrow.
I've read everything under ocaml
. Please also find appropriate reviewers for the middleend and backend bits. (It may make sense for them to review the tests as well, but probably you'll want to address my requests for more tests first)
@mshinwell has looked over the changes under |
Not really, I just had a question! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved for the front-end bits. Obviously don't merge until we're also ready to merge the PRs fixing the fatal errors.
Vec128
sort and unboxed versions of our 128-bit simd vector types.Reviewable by commit.
Three features remain unsupported:
Currently the compiler will raise in these cases, but they will be addressed in later PRs.