Unsigned comparisons #2812
Draft
Unsigned comparisons #2812
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheNumbat
reviewed
Aug 13, 2024
| @@ -60,15 +61,15 @@ type comparison = | |||
| | Compare | |||
|
|
|||
| type comparison_kind = | |||
| | Compare_generic | |||
| | Compare_ints | |||
| | Compare_generic of { signed : bool } | |||
There was a problem hiding this comment.
Polymorphic comparison probably shouldn't have an unsigned option, right?
There was a problem hiding this comment.
Right. They all start as Compare_generic in lookup_primitive. I will try to move this bool to the Comparison constructor of prim, it'll be cleaner. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The middle-end/backend can already emit unsigned comparisons. This PR exposes them as the following new builtins to the users:
%lessequal_unsigned%lessthan_unsigned%greaterequal_unsigned%greaterthan_unsignedandcompare_unsignedfor int and boxed/unboxed int32/int64/nativeint, reusing the existing typed-based translation of compare primitives.The main changes are in
LambdaandTranslprim. The rest of the PR is refactoring to propagate the signed/unsigned information to the middle end.This is a draft because it's completely untested.