Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant CU.Name.t from normal import info #2609

Closed
wants to merge 1 commit into from
Closed

Remove redundant CU.Name.t from normal import info #2609

wants to merge 1 commit into from

Conversation

lukemaurer
Copy link
Contributor

@lukemaurer lukemaurer commented May 23, 2024 •
edited
Loading

Needs #1753 and #2585 to be un-reverted before it can be merged.

When we have both a CU.Name.t and a CU.t, they must always match, so storing the CU.Name.t is redundant.

@lukemaurer
Remove redundant CU.Name.t from normal import info
305ef3a 
When we have both a `CU.Name.t` and a `CU.t`, they must always match, so
storing the `CU.Name.t` is redundant.
@lukemaurer lukemaurer mentioned this pull request May 24, 2024
Merged
@lukemaurer
Copy link
Contributor Author

This got cherry-picked into #2621 and merged in that form.

@lukemaurer lukemaurer closed this May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xclerc xclerc xclerc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukemaurer @xclerc