-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move down the stack check if possible #2373
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(As noted offline by @stedolan, it would |
xclerc
force-pushed
the
stack-check-explicit-instruction
branch
from
March 25, 2024 10:34
bc4ab1d
to
334e55f
Compare
mshinwell
approved these changes
Apr 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is ok to merge once the Specific_can_raise match has been made exhaustive, and maybe "is a non-tail call" moved into Cfg itself, as discussed elsewhere.
Forestryks
pushed a commit
to Forestryks/flambda-backend
that referenced
this pull request
Apr 17, 2024
samsa1
pushed a commit
to samsa1/flambda-backend
that referenced
this pull request
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes the logic behind the
insertion of the stack check. Instead of always
emitting it at the top of the function, we try to
"push it down" so that it is executed only when
necessary.
In order to determine where to emit the check, we:
be executed after the check;
the number of nodes in the subtree that need
the check;
of the smallest subtree that contains all block
that must only be executed after the check.
The new beahviour is controlled by a command-line
flag, namely
-cfg-stack-checks
, and disabled bydefault.