Add tests for function parameter/return unboxing #2321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lthls
reviewed
Feb 29, 2024
|
This isn't ready yet, @mshinwell to try reproducing the failure on |
|
@mshinwell ping ? |
lthls
reviewed
Aug 29, 2024
| that if it had any allocation, the number of minor words allocated would be | ||
| a lot bigger than the threshold we check for. *) | ||
| let test_allocs test_name f arg1 arg2 = | ||
| let (minor, promoted, major) = Gc.counters () in |
There was a problem hiding this comment.
Gc.minor_words looks more interesting (and doesn't allocate in native mode)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some tests following #1271 .
These tests actually show that #2319 missed one spot when it renamed the attribute.
Also, it appears that the location of the warning is not always exact: indeed, as can be show in the compilers reference for the added tests, we have two warnings as expected, but both quote the same location, which is less than ideal since this means we cannot distinguish the warning for the annotation on the parameter from the warning on the annotation of the function return, cc @Ekdohibs .