Skip to content

Fix failure of check_all_arches on RISCV #1300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 12, 2023
Merged

Fix failure of check_all_arches on RISCV #1300

merged 2 commits into from
Apr 12, 2023

Conversation

Ekdohibs
Copy link
Contributor

This was broken by the ocaml-jst merge on October 31st.

@gretay-js
Copy link
Contributor

We should run this build target in the CI of [ocaml-flambda/ocaml-jst] to keep it from breaking again, and have this fix there directly.

@Ekdohibs
Copy link
Contributor Author

I added a commit checking that; it does so by modifying the build_and_test_upstream target in the Makefile making it run check_all_arches, since I consider checking that it builds on other architectures part of the tests (I didn't want to put it in the build phase, as it is quite slow).
I hope the CI will not become too long; check_all_arches is quite slow on my machine in any case.

@gretay-js
Copy link
Contributor

I added a commit checking that; it does so by modifying the build_and_test_upstream target in the Makefile making it run check_all_arches, since I consider checking that it builds on other architectures part of the tests

it seems fine to me. we may need to add something similar for ocaml-jst because this Makefile is only for flambda-backend ,right?

@mshinwell can you please have a look at this change as code owner of the build parrt (not sure why github didn't request you review automatically).

(I didn't want to put it in the build phase, as it is quite slow).

yes, and also check_all_arches leaves the directories in a weird state that won't be good for running tests in.

@gretay-js gretay-js requested a review from mshinwell April 12, 2023 08:14
@mshinwell
Copy link
Collaborator

This seems fine to me. When we decide how to merge ocaml-jst and flambda-backend, we can make sure this test gets run.

@mshinwell mshinwell merged commit c0e2850 into ocaml-flambda:main Apr 12, 2023
mshinwell added a commit to mshinwell/flambda-backend that referenced this pull request Apr 28, 2023
@mshinwell
Squashed 'ocaml/' changes from ea89813..a7d005a
4d0fa29 
a7d005a flambda-backend: Lazy deserialization of cmi files (ocaml-flambda#1322)
aa83fa3 flambda-backend: Reinstate previous API for Env.lookup_value (ocaml-flambda#1323)
e4007a4 flambda-backend: Lazy substitution into value_declaration (ocaml-flambda#1320)
634b607 flambda-backend: Merge Types.* and Subst.Lazy.* types (ocaml-flambda#1312)
cf82708 flambda-backend: Bump magic numbers for 4.14.1-7 (ocaml-flambda#1317)
6470400 flambda-backend: zero_alloc attribute payload "assert all" and "ignore" (ocaml-flambda#1296)
bba5248 flambda-backend: Teach `ocamldep` about all the language extensions (ocaml-flambda#1303)
33e97b0 flambda-backend: Change Includemod to work on lazy modtypes (ocaml-flambda#1228)
16e5002 flambda-backend: zero_alloc new warning for unchecked functions (ocaml-flambda#1302)
36b4626 flambda-backend: Attribute [@@@zero_alloc check] to turn the check on (ocaml-flambda#1294)
3b524c6 flambda-backend: Cmm.value_kind cleanup (ocaml-flambda#1091)
ec99505 flambda-backend: Fix failure of `check_all_arches` on RISCV (ocaml-flambda#1300)
450bc58 flambda-backend: Backend changes for multiple returns (ocaml-flambda#1268)
84a7a26 flambda-backend: Static check for zero_alloc: ignore allocation that lead to exceptional return (ocaml-flambda#1157)
1723728 flambda-backend: Re-enable parallel build of the runtime (ocaml-flambda#1287)
26ea7f3 flambda-backend: Fix closure marshalling when not in NNP mode (ocaml-flambda#1286)
9b91f2e flambda-backend: Reduce number of caml_apply functions taking/returning "I" and "V" (ocaml-flambda#1272)
1686928 flambda-backend: Restore Cmm unboxing behaviour inside regions (ocaml-flambda#1285)
cf9be42 flambda-backend: Fix all the no-naked-pointers problems (ocaml-flambda#1282)
8fe089e flambda-backend: Unrevert ocaml-flambda#1131 and fix a Cmm unboxing bug (ocaml-flambda#1284)
c4143c3 flambda-backend: Revert "Make Selectgen treat region boundaries more precisely" (ocaml-flambda#1283)
2078dce flambda-backend: Add some -dtimings output for the typechecker (ocaml-flambda#1245)
273a7f9 flambda-backend: Make Selectgen treat region boundaries more precisely (ocaml-flambda#1131)
47610e6 flambda-backend: Bump magic numbers for 4.14.1-6 (ocaml-flambda#1274)
fd53d38 flambda-backend: Generate *.cms files for merlin (ocaml-flambda#1232)
853f95f flambda-backend: Add tail_mod_const to builtin_attrs (ocaml-flambda#1265)
f9ef051 flambda-backend: Fix issue caused by effects of gadt expansion in mode cross check (ocaml-flambda#1263)
e9ffcf8 flambda-backend: Fix dependencies for regenerating Flambda2 parser, tests (ocaml-flambda#1255)
6f1cd1f flambda-backend: Restore a lost location, needed for merlin (ocaml-flambda#1242)
009332b flambda-backend: Fix merge from ocaml-jst

git-subtree-dir: ocaml
git-subtree-split: a7d005a
ccasin added a commit to ccasin/flambda-backend that referenced this pull request Apr 29, 2023
@ccasin
Squashed 'ocaml/' changes from ea89813..a7d005a
35bb136 
a7d005a flambda-backend: Lazy deserialization of cmi files (ocaml-flambda#1322)
aa83fa3 flambda-backend: Reinstate previous API for Env.lookup_value (ocaml-flambda#1323)
e4007a4 flambda-backend: Lazy substitution into value_declaration (ocaml-flambda#1320)
634b607 flambda-backend: Merge Types.* and Subst.Lazy.* types (ocaml-flambda#1312)
cf82708 flambda-backend: Bump magic numbers for 4.14.1-7 (ocaml-flambda#1317)
6470400 flambda-backend: zero_alloc attribute payload "assert all" and "ignore" (ocaml-flambda#1296)
bba5248 flambda-backend: Teach `ocamldep` about all the language extensions (ocaml-flambda#1303)
33e97b0 flambda-backend: Change Includemod to work on lazy modtypes (ocaml-flambda#1228)
16e5002 flambda-backend: zero_alloc new warning for unchecked functions (ocaml-flambda#1302)
36b4626 flambda-backend: Attribute [@@@zero_alloc check] to turn the check on (ocaml-flambda#1294)
3b524c6 flambda-backend: Cmm.value_kind cleanup (ocaml-flambda#1091)
ec99505 flambda-backend: Fix failure of `check_all_arches` on RISCV (ocaml-flambda#1300)
450bc58 flambda-backend: Backend changes for multiple returns (ocaml-flambda#1268)
84a7a26 flambda-backend: Static check for zero_alloc: ignore allocation that lead to exceptional return (ocaml-flambda#1157)
1723728 flambda-backend: Re-enable parallel build of the runtime (ocaml-flambda#1287)
26ea7f3 flambda-backend: Fix closure marshalling when not in NNP mode (ocaml-flambda#1286)
9b91f2e flambda-backend: Reduce number of caml_apply functions taking/returning "I" and "V" (ocaml-flambda#1272)
1686928 flambda-backend: Restore Cmm unboxing behaviour inside regions (ocaml-flambda#1285)
cf9be42 flambda-backend: Fix all the no-naked-pointers problems (ocaml-flambda#1282)
8fe089e flambda-backend: Unrevert ocaml-flambda#1131 and fix a Cmm unboxing bug (ocaml-flambda#1284)
c4143c3 flambda-backend: Revert "Make Selectgen treat region boundaries more precisely" (ocaml-flambda#1283)
2078dce flambda-backend: Add some -dtimings output for the typechecker (ocaml-flambda#1245)
273a7f9 flambda-backend: Make Selectgen treat region boundaries more precisely (ocaml-flambda#1131)
47610e6 flambda-backend: Bump magic numbers for 4.14.1-6 (ocaml-flambda#1274)
fd53d38 flambda-backend: Generate *.cms files for merlin (ocaml-flambda#1232)
853f95f flambda-backend: Add tail_mod_const to builtin_attrs (ocaml-flambda#1265)
f9ef051 flambda-backend: Fix issue caused by effects of gadt expansion in mode cross check (ocaml-flambda#1263)
e9ffcf8 flambda-backend: Fix dependencies for regenerating Flambda2 parser, tests (ocaml-flambda#1255)
6f1cd1f flambda-backend: Restore a lost location, needed for merlin (ocaml-flambda#1242)
009332b flambda-backend: Fix merge from ocaml-jst

git-subtree-dir: ocaml
git-subtree-split: a7d005a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gretay-js gretay-js gretay-js approved these changes

@xclerc xclerc Awaiting requested review from xclerc

@mshinwell mshinwell Awaiting requested review from mshinwell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ekdohibs @gretay-js @mshinwell