Skip to content

Commit 03ccfed

Browse files
committed
Rename SANDMARK_CUSTOM_NAME to VARIANT_NAME
Closes #347
1 parent 2f440d8 commit 03ccfed

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

Makefile

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -232,7 +232,7 @@ blah:
232232
@echo ${PACKAGES}
233233

234234
ocaml-versions/%.bench: depend check-parallel/% filter/% override_packages/% log_sandmark_hash ocaml-versions/%.json .FORCE
235-
$(eval SANDMARK_CUSTOM_NAME ?= $*)
235+
$(eval VARIANT_NAME ?= $*)
236236
$(eval CONFIG_SWITCH_NAME = $*)
237237
$(eval CONFIG_OPTIONS = $(shell jq -r '.configure // empty' ocaml-versions/$*.json))
238238
$(eval CONFIG_RUN_PARAMS = $(shell jq -r '.runparams // empty' ocaml-versions/$*.json))
@@ -262,8 +262,8 @@ ocaml-versions/%.bench: depend check-parallel/% filter/% override_packages/% log
262262
fi; \
263263
done; \
264264
header_entry=`jo -p $${s} | jq -c`; \
265-
echo "$${header_entry}" > _results/$(SANDMARK_CUSTOM_NAME)_$$i.$(WRAPPER).summary.bench; \
266-
find _build/$(CONFIG_SWITCH_NAME)_$$i -name '*.$(WRAPPER).bench' | xargs cat >> _results/$(SANDMARK_CUSTOM_NAME)_$$i.$(WRAPPER).summary.bench; \
265+
echo "$${header_entry}" > _results/$(VARIANT_NAME)_$$i.$(WRAPPER).summary.bench; \
266+
find _build/$(CONFIG_SWITCH_NAME)_$$i -name '*.$(WRAPPER).bench' | xargs cat >> _results/$(VARIANT_NAME)_$$i.$(WRAPPER).summary.bench; \
267267
done; \
268268
exit $$ex; \
269269
else \

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -210,7 +210,7 @@ benchmarks in byte mode:
210210

211211
```bash
212212
$ opam install dune.2.9.0
213-
$ USE_SYS_DUNE_HACK=1 SANDMARK_CUSTOM_NAME=5.0.0 BUILD_BENCH_TARGET=bytebench \
213+
$ USE_SYS_DUNE_HACK=1 VARIANT_NAME=5.0.0 BUILD_BENCH_TARGET=bytebench \
214214
RUN_CONFIG_JSON=run_config_byte.json make ocaml-versions/5.0.0+stable.bench
215215
```
216216

@@ -381,11 +381,11 @@ work on OS X is to install GNU sed with homebrew and then update the
381381
| PRE_BENCH_EXEC | Any specific commands that needed to be executed before the benchmark. For eg. `PRE_BENCH_EXEC='taskset --cpu-list 3 setarch uname -m --addr-no-randomize'` | null string | executing benchmark | RUN_BENCH_TARGET | The executable to be used to run the benchmarks | `run_orun` | executing benchmark |
382382
| RUN_BENCH_TARGET | The executable to be used to run the benchmarks | `run_orun` | executing benchmark |
383383
| RUN_CONFIG_JSON | Input file selection that contains the list of benchmarks | `run_config.json` | executing benchmark |
384-
| SANDMARK_CUSTOM_NAME | Custom name to use for the bench output file | variant from the `ocaml-version/<variant>.json` file name | executing benchmark |
385384
| SANDMARK_DUNE_VERSION | Default dune version to be used | 2.9.0 | building compiler and its dependencies |
386385
| SANDMARK_OVERRIDE_PACKAGES | A list of dependency packages with versions that can be overrided (optional) | "" | building compiler and its dependencies |
387386
| SANDMARK_REMOVE_PACKAGES | A list of dependency packages to be dynamically removed (optional) | "" | building compiler and its dependencies |
388387
| SANDMARK_URL | OCaml compiler source code URL used to build the benchmarks | "" | building compiler and its dependencies |
389388
| SYS_DUNE_BASE_DIR | Function that returns the path of the system installed dune for use with benchmarking | dune package present in the local opam switch | building compiler and its dependencies |
390389
| USE_SYS_DUNE_HACK | If the value is 1 then use system installed dune | 0 | building compiler and its dependencies |
390+
| VARIANT_NAME | Custom name to use for the bench output file | variant from the `ocaml-version/<variant>.json` file name | executing benchmark |
391391
| WRAPPER | Function to get the wrapper out of `run_<wrapper-name>` | run_orun | executing benchmark |

run_all_custom.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@ for i in $(seq 0 $((${COUNT} - 1))); do
155155
ENVIRONMENT="`echo ${CONFIG_ENVIRONMENT}`" \
156156
OCAML_CONFIG_OPTION="`echo ${CONFIG_OPTIONS}`" \
157157
OCAML_RUN_PARAM="`echo ${CONFIG_RUN_PARAMS}`" \
158-
SANDMARK_CUSTOM_NAME="`echo ${CONFIG_NAME}`" \
158+
VARIANT_NAME="`echo ${CONFIG_NAME}`" \
159159
SANDMARK_OVERRIDE_PACKAGES="`echo ${CONFIG_OVERRIDE_PACKAGES}`" \
160160
SANDMARK_REMOVE_PACKAGES="`echo ${CONFIG_REMOVE_PACKAGES}`" \
161161
RUN_BENCH_TARGET="`echo ${CONFIG_RUN_BENCH_TARGET}`" \

0 commit comments

Comments
 (0)