Sync non-empty branch with upstream #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix Haddocks for `mapAccumRWithKey`
Simply import `GHC.Exts` fully qualified to avoid fussy CPP.
This submodule appears to have been errenously removed in [30ccbaa]. [30ccbaa]: haskell@30ccbaa#diff-fc048ebf98a95fc8a8ff9c949d9b49a9.
deleteFindMin was missing the map argument (`empty`).
Make previously (grandfathered) ReadTheDocs configuration explicit. This is in preparation for upgrading to Python 3 which is the default on ReadTheDocs now. [ci skip]
- Update .readthedocs.yml - Use Python 3 compatible haddock-autolink Sphinx extension. [ci skip]
Make `(<*)` for `Data.Sequence` incrementally asymptotically optimal. This finally completes the task, begun in December 2014, of making all the `Applicative` methods for sequences asymptotically optimal even when their results are consumed incrementally.
Remove the explicit intermediate spine structure from `(<*)`. I don't really know if this is a good or a bad thing from a clarity standpoint.
* Document the invariants of `raptyMiddle`. * Simplify some of the arithmetic. * Reorganize the arguments for clarity.
Reimplement (<*) for sequences.
* Make Map an instance of Bifoldable * Replace the Arbitrary instance for Map with an adaptation of the one from Set * Use a Map and toList instead of a list and fromList
Add 'compose' for maps
* Add Data.IntSet.alterF Fixes haskell#719. * Add Const rule and specialize for Identity * Add tests * Docs * Work around missing Show instance for Const in GHC 7.8
- Renamed aptyMiddle to liftA2Middle and some of its parameters - Document invariants and meaning of parameters. - A short note about sharing related to ffirstx, flastx, and f.
* Mention Data.IntSet.alterF in changelog * Mention Li-Yao Xia in documentation bullet point.
Updates the definition of `Monoid (Seq a)` to use canonical definition of `mappend`, allowing https://gitlab.haskell.org/ghc/ghc/-/merge_requests/3174 to pass
Context: haskell#717
Hackage now requires `cabal-version >= 1.10`.
Add `default-language` field all over the place.
Add `Lift` instances for `Seq`, `ViewL`, and `ViewR`. The `Seq` instance tries to be a bit clever about the shape of the resulting tree and the size of the splice; everything else is straightforward.
Add `Lift` instances for `Data.Map.Map`, `Data.Set.Set`, `Data.IntSet.IntSet`, `Data.IntMap.IntMap`, `Data.Tree.Tree`, and `Data.Graph.SCC`.
Typo and reword
Co-authored-by: David Feuer <David.Feuer@gmail.com>
Test with 9.4 and head.
Use a private `Prelude` temporarily to deal with warnings arising from the fact that `liftA2` hasn't always been exposed in the `Prelude`. Other approaches seemed to involve too much CPP or required disabling redundant import warnings, which we really don't want.
I don't see a warning, but it seems a bit silly to export `Applicative (..)` explicitly from the custom prelude when `base >= 4.18.0`. Let's not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Ericson2314