Handle <br /> nodes in preformattedCode #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #145
In preformatted code blocks highlighted by hljs, there are
<br />elements used to break up newlines. These weren't getting handled byextractStructuredText, so I added a handler for it.When working on this, I noticed another issue: it appears that comments are getting stripped from hljs code blocks 😱 if you try the clipper out on the medium article linked in #145, you can see that aside from newlines, comments are missing. This seems a little more tricky, because by the time the
contentmakes it's way to the preformattedCode rule, it's already missing comments.I can open up a separate ticket for that if it would be helpful :)