feat: Add Reminders fields and Notifications #1925
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tings. It is now the only allowed value in settings anyway.
…tings. It is now the only allowed value in settings anyway.
Code now uses TIME_FORMATS.twentyFourHour directly instead. This is part of moving towards compatibility with the Reminders plugin
For more detailed output on failure.
This definitely needs more work. Users will be confused and miss out on tasks they will probably think should match.
I will have to document that it's not possible to search for tasks with reminders at a particular time of day.
In reminders settings you can set a custom format like so. It's what I was using, but not sure how much of it working is on purpose or as a result of how forgiving moment.js is with parsing. Also, I think I remember reading that reminders requires the emoji to be the first one? In order to parse it correctly. |
15 tasks
The presence and absence ones remain, for consistency with the other date fields.
As one reminder, at most, is now supported
As only at most one value is now supported.
# Conflicts: # src/Config/SettingsTab.ts # src/Task.ts # src/TaskLineRenderer.ts # tests/Query.test.ts # tests/TestingTools/TaskBuilder.ts
2 tasks
4 tasks
26 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds native reminder support to tasks without the need of a plugin.
Motivation and Context
Had some issues with existing external plugin and figured a built-in solutions would help solve some of those issues and simplify things.
Fixes #1854
How has this been tested?
Tests have been created for the new fields and for some query filters. More tests are need for notifications
Screenshots (if appropriate)
Types of changes
Changes visible to users:
fix- non-breaking change which fixes an issue)feat- non-breaking change which adds functionality)feat!!orfix!!- fix or feature that would cause existing functionality to not work as expected)docs- improvements to any documentation content for users)vault- improvements to the Tasks-Demo sample vault)contrib- any improvements to documentation content for contributors - see Contributing to Tasks)Internal changes:
refactor- non-breaking change which only improves the design or structure of existing code, and making no changes to its external behaviour)test- additions and improvements to unit tests and the smoke tests)chore- examples include GitHub Actions, issue templates)Checklist
yarn run lint.Terms
Left To-do