Skip to content

Commit 0b118ae

Browse files
luke-zhuluke
and
luke
authored
fix(cloudwatch_metrics): correct rule schedule expression (#62)
The schedule previously ran once an hour. I tested 1 minute, 5 minutes, and 3 hours Co-authored-by: luke <luke@observeinc.com>
1 parent 2ca2542 commit 0b118ae

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

modules/cloudwatch_metrics/main.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ resource "aws_iam_role_policy_attachment" "this" {
3939
resource "aws_cloudwatch_event_rule" "trigger" {
4040
name_prefix = var.eventbridge_name_prefix
4141
description = "Periodically trigger Observe Lambda to collect CloudWatch metrics"
42-
schedule_expression = "cron(${var.interval / 60} * * * ? *)"
42+
schedule_expression = var.interval == 60 ? "rate(1 minute)" : "rate(${var.interval / 60} minutes)"
4343
event_bus_name = var.eventbridge_schedule_event_bus_name
4444
}
4545

modules/cloudwatch_metrics/variables.tf

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,8 @@ variable "interval" {
3535
nullable = false
3636
default = 300
3737
validation {
38-
condition = var.interval >= 60 && var.interval < 3600
39-
error_message = "interval must be greater than or equal to 60 and less than 3600."
38+
condition = var.interval >= 60 && var.interval <= 10800
39+
error_message = "interval must be in [60, 10800] (1 minute to 3 hours)"
4040
}
4141
}
4242

0 commit comments

Comments
 (0)