Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch is trying to fix the following issue:
When we have "sort fy by x" and a transform, the series are not indexed properly. The channel to sort (XV, in this case fy) is indexed by the original data, and the channel by which to sort (YV, in this case x) is indexed by the transformed (grouped) data.
It can be solved, in the case of this unit test, by grouping data by series:
However this is not a proper fix, since it should apply only when data is indeed grouped this way. We have to understand how the data is reindexed, or alternatively we have to make the facet information follow along with the grouping.
Note: the broken test is the expected chart, but we can't achieve it yet without breaking a few others:
cc: @enjalot