Skip to content

default tip for auto #1546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 15, 2023
Merged

default tip for auto #1546

merged 5 commits into from
May 15, 2023

Conversation

mbostock
Copy link
Member

Supersedes #1532.

@mbostock mbostock requested a review from tophtucker May 13, 2023 18:22
@mbostock mbostock force-pushed the mbostock/auto-tip branch 2 times, most recently from 721301c to 6bdd082 Compare May 13, 2023 18:42
@mbostock mbostock requested a review from Fil May 15, 2023 16:19
@mbostock
Copy link
Member Author

mbostock commented May 15, 2023

Since @tophtucker is out, do you want to review @Fil? I wonder if e.g. #1547 is a blocker.

@mbostock mbostock force-pushed the mbostock/auto-tip branch from 6bdd082 to c98e56d Compare May 15, 2023 16:39
Copy link
Contributor

@Fil Fil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1547 will be nice to have, but not blocking for this PR

@mbostock
Copy link
Member Author

I don’t have a good fix for the challenges of doing server-side rendering with Vue while adding interaction during client-side hydration. The problem is the pointer interaction captures a reference to the DOM element during the initial render, but this is Vue’s virtual DOM node, which isn’t what we want, and I don’t know if it’s feasible for us to maintain a mapping from the virtual DOM node to the corresponding real one after Vue renders.

But anyway, we can just defer rendering to client-side for interactive charts for now. If we can figure out a way to opt-out of Vue’s client-side hydration, then we could restore server-side rendering but replace it with the real DOM on the client.

@mbostock mbostock force-pushed the mbostock/auto-tip branch from d70295d to 5e28846 Compare May 15, 2023 20:45
@mbostock mbostock enabled auto-merge (squash) May 15, 2023 20:46
@mbostock mbostock merged commit ccaa681 into main May 15, 2023
@mbostock mbostock deleted the mbostock/auto-tip branch May 15, 2023 20:48
@tophtucker
Copy link
Contributor

wow tip: true easy!!

chaichontat pushed a commit to chaichontat/plot that referenced this pull request Jan 14, 2024
* default tip for auto

* use real DOM during hydration

* fix unit tests

* defer for auto mark

* update comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants