-
Notifications
You must be signed in to change notification settings - Fork 184
default tip for auto #1546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
default tip for auto #1546
Conversation
721301c
to
6bdd082
Compare
Since @tophtucker is out, do you want to review @Fil? I wonder if e.g. #1547 is a blocker. |
6bdd082
to
c98e56d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#1547 will be nice to have, but not blocking for this PR
605a910
to
8418386
Compare
I don’t have a good fix for the challenges of doing server-side rendering with Vue while adding interaction during client-side hydration. The problem is the pointer interaction captures a reference to the DOM element during the initial render, but this is Vue’s virtual DOM node, which isn’t what we want, and I don’t know if it’s feasible for us to maintain a mapping from the virtual DOM node to the corresponding real one after Vue renders. But anyway, we can just defer rendering to client-side for interactive charts for now. If we can figure out a way to opt-out of Vue’s client-side hydration, then we could restore server-side rendering but replace it with the real DOM on the client. |
d70295d
to
5e28846
Compare
wow |
* default tip for auto * use real DOM during hydration * fix unit tests * defer for auto mark * update comment
Supersedes #1532.