Skip to content

Commit 96a659c

Browse files
committed
propagate domain sort in basic transforms
1 parent e52a782 commit 96a659c

File tree

3 files changed

+2224
-7
lines changed

3 files changed

+2224
-7
lines changed

src/transforms/basic.js

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -76,25 +76,30 @@ function filterTransform(value) {
7676
}
7777

7878
/** @jsdoc reverse */
79-
export function reverse(options) {
80-
return {...apply(options, reverseTransform), sort: null};
79+
export function reverse({sort, ...options} = {}) {
80+
return {
81+
...apply(options, reverseTransform),
82+
sort: isDomainSort(sort) ? sort : null
83+
};
8184
}
8285

8386
function reverseTransform(data, facets) {
8487
return {data, facets: facets.map((I) => I.slice().reverse())};
8588
}
8689

8790
/** @jsdoc shuffle */
88-
export function shuffle(options = {}) {
89-
const {seed, ...remainingOptions} = options;
90-
return {...apply(remainingOptions, sortValue(seed == null ? Math.random : randomLcg(seed))), sort: null};
91+
export function shuffle({seed, sort, ...options} = {}) {
92+
return {
93+
...apply(options, sortValue(seed == null ? Math.random : randomLcg(seed))),
94+
sort: isDomainSort(sort) ? sort : null
95+
};
9196
}
9297

9398
/** @jsdoc sort */
94-
export function sort(order, options) {
99+
export function sort(order, {sort, ...options} = {}) {
95100
return {
96101
...(isOptions(order) && order.channel !== undefined ? initializer : apply)(options, sortTransform(order)),
97-
sort: null
102+
sort: isDomainSort(sort) ? sort : null
98103
};
99104
}
100105

0 commit comments

Comments
 (0)