Skip to content

Commit 1a44195

Browse files
authored
feat!: remove FacebookConceal and library warmup, upgrade minAndroidSdk (#719)
1 parent d19246d commit 1a44195

24 files changed

+2901
-3915
lines changed

KeychainExample/android/gradle.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ android.useAndroidX=true
2727
# Automatically convert third-party libraries to use AndroidX
2828
android.enableJetifier=true
2929
# Jetifier randomly fails on these libraries
30-
android.jetifier.ignorelist=hermes-android
30+
android.jetifier.ignorelist=hermes-android,react-android
3131

3232
# Use this property to specify which architecture you want to build.
3333
# You can also override it from the CLI using

KeychainExample/android/gradle/wrapper/gradle-wrapper.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
distributionBase=GRADLE_USER_HOME
22
distributionPath=wrapper/dists
3-
distributionUrl=https\://services.gradle.org/distributions/gradle-8.6-bin.zip
3+
distributionUrl=https\://services.gradle.org/distributions/gradle-8.11.1-bin.zip
44
networkTimeout=10000
55
validateDistributionUrl=true
66
zipStoreBase=GRADLE_USER_HOME

KeychainExample/e2e/testCases/storageTypesTest.spec.js

Lines changed: 0 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -7,42 +7,6 @@ describe(':android:Storage Types', () => {
77
await device.launchApp({ newInstance: true });
88
});
99
['genericPassword', 'internetCredentials'].forEach((type) => {
10-
it(
11-
':android:should save with FB storage and migrate it to AES_GCM_NO_AUTH - ' +
12-
type,
13-
async () => {
14-
await expect(element(by.text('Keychain Example'))).toExist();
15-
await element(by.id('usernameInput')).typeText('testUsernameFB');
16-
await element(by.id('passwordInput')).typeText('testPasswordFB');
17-
// Hide keyboard
18-
await element(by.text('Keychain Example')).tap();
19-
20-
await element(by.text(type)).tap();
21-
await element(by.text('None')).tap();
22-
await element(by.text('No upgrade')).tap();
23-
await element(by.text('FB')).tap();
24-
25-
await expect(element(by.text('Save'))).toBeVisible();
26-
await element(by.text('Save')).tap();
27-
await expect(element(by.text(/^Credentials saved! .*$/))).toBeVisible();
28-
await element(by.text('Load')).tap();
29-
await matchLoadInfo(
30-
'testUsernameFB',
31-
'testPasswordFB',
32-
'FacebookConceal',
33-
type === 'internetCredentials' ? 'https://example.com' : undefined
34-
);
35-
await element(by.text('Automatic upgrade')).tap();
36-
await element(by.text('Load')).tap();
37-
await matchLoadInfo(
38-
'testUsernameFB',
39-
'testPasswordFB',
40-
'KeystoreAESGCM_NoAuth',
41-
type === 'internetCredentials' ? 'https://example.com' : undefined
42-
);
43-
}
44-
);
45-
4610
it(':android:should save with AES_CBC storage - ' + type, async () => {
4711
await expect(element(by.text('Keychain Example'))).toExist();
4812
await element(by.id('usernameInput')).typeText('testUsernameAESCBC');

0 commit comments

Comments
 (0)