Use host.docker.internal instead of local IP address in chrome.docker #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamiepenney
force-pushed
the
bugfix/473-fix-chrome-docker-host-access
branch
from
65129bc
to
2e8e084
Compare
|
This also works for me on 0.34.0! Would be great to have this merged :) |
|
it actually works, ty (: |
|
Same here, seems to be resolving the issue. |
Resolves oblador#473 Fixes an issue where the Chrome docker container cannot access Storybook running on the host machine via IP address, instead using the Docker `host.docker.internal` DNS entry to get access to it.
jamiepenney
force-pushed
the
bugfix/473-fix-chrome-docker-host-access
branch
from
05aef2e
to
444871c
Compare
|
Hey @techeverri, @oblador Pushing it forward would resolve CI issues with which people are currently struggling. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #473
Fixes an issue where the Chrome docker container cannot access Storybook running on the host machine via IP address, instead using the Docker
host.docker.internalDNS entry to get access to it.I'm not 100% convinced this is the right approach, but I wanted to put it out there as a solution to my problem. Is there a scenario where using
host.docker.internalfor accessing the host from the docker container won't work?