fix(chatbot): type ChatToolInvocation.draftReview as DraftReview so the published type declares kind (objectui#10109)

The inline copy of DraftReview's fields on ChatToolInvocation.draftReview stopped matching when DraftReview gained the producer's optional kind, so ChatbotEnhancedToolInvocation under-declared what the runtime delivers. It now references DraftReview; the copy's field docs move onto DraftReview so the published type keeps them. AiChatPage's DraftReview upcast is redundant and is dropped (type-only, same emitted code). The DraftReview.kind doc names the readers that actually check it.

Claude-Session: https://claude.ai/code/session_014mXUNuFomfj24w7s1pZzhN
Co-authored-by: Claude <noreply@anthropic.com>

Author: claude

.changeset/10109-edit-envelope-not-built-app.md

@@ -6,6 +6,7 @@ An incremental edit is no longer read as a whole-app build. An `apply_edit` resu
 
 - `detectBuiltAppPackage` returns `undefined` for an envelope that says `kind: 'edit'`, in both the drafted and the auto-publish (`status: 'published'`) postures.
 - `DraftReview` has a new optional `kind?: 'edit'`, and `detectDraftResult` fills it from the envelope. The edit still gets its draft card, its items and its `packageId`, so one-click publish still works.
+- `ChatbotEnhancedToolInvocation['draftReview']` (`ChatToolInvocation.draftReview`) is now typed as `DraftReview` instead of an inline copy of its fields, so it declares `kind` too. The two were field-identical before this change, and the published tool-invocation type now describes exactly what the chat mapper puts on it.
 - `buildProgressFromDraftReview` builds no finished "Built X" panel for a draft review whose `kind` is `'edit'`, so a reloaded edit shows the same thing it showed live.
 
 An envelope without `kind` behaves as before. `DraftReview.kind` declares only the value these readers act on, and an envelope that says anything else leaves it unset.

packages/app-shell/src/console/ai/AiChatPage.tsx

@@ -87,7 +87,6 @@ import {
   toRuntimeMessages,
   type AgentDescriptor,
   type ChatbotEnhancedToolInvocation,
-  type DraftReview,
   // The ENHANCED message shape — the one `<ChatbotEnhanced>` renders and the
   // one this file actually produces (`toolInvocations`, `buildProgress`).
   //
@@ -2032,9 +2031,7 @@ export function ChatPane({
         if (pkg) return pkg;
         // objectui#10109 — an INCREMENTAL edit's draft review can list the `app`
         // it re-staged; the producer's `kind: 'edit'` says it is not a build.
-        // Read through the detector's own `DraftReview`, which declares that
-        // `kind` (every draft review here is minted by `detectDraftResult`).
-        const dr: DraftReview | undefined = tool.draftReview;
+        const dr = tool.draftReview;
         if (dr?.packageId && dr.kind !== 'edit' && dr.items?.some((it) => it.type === 'app')) {
           return dr.packageId;
         }

packages/plugin-chatbot/src/ChatbotEnhanced.tsx

@@ -82,7 +82,7 @@ import {
   SourcesContent,
   Source,
 } from './elements/sources';
-import { parseResultEnvelope, detectAuthoringVerdict } from './mapMessages';
+import { parseResultEnvelope, detectAuthoringVerdict, type DraftReview } from './mapMessages';
 
 export interface ChatMessage {
   id: string;
@@ -268,43 +268,13 @@ export interface ChatToolInvocation {
    * lifts the reviewable targets here so chat UIs can render a "Review N
    * change(s)" affordance that opens the designer's review/diff. Nothing is
    * live until the human publishes — this is the review entry point.
+   *
+   * The shape is `mapMessages.ts`'s `DraftReview`, the type `detectDraftResult`
+   * returns, referenced rather than repeated: an inline copy of its fields
+   * drifted the moment `DraftReview` gained the producer's `kind`
+   * (objectui#10109).
    */
-  draftReview?: {
-    items: Array<{ type: string; name: string }>;
-    summary?: string;
-    packageId?: string;
-    /**
-     * Backend lifecycle intent (from the tool result). `true` for whole-app
-     * builds (apply_blueprint) — eligible for the auto-publish "magic moment".
-     * Omitted for incremental edits, which stay drafts for explicit review.
-     */
-    autoPublishable?: boolean;
-    /** Count of artifacts that failed in a partial build, surfaced not hidden. */
-    failedCount?: number;
-    /**
-     * ADR-0045: the build was MATERIALIZED in-turn — real tables and seed
-     * rows exist; the app is live but `hidden` (unlisted). Preview should
-     * open the REAL app URL, not the draft overlay.
-     */
-    materialized?: boolean;
-    /**
-     * ADR-0038 L1 graph-lint verdict for the staged build. Rendered as a
-     * verified/issues chip so "drafted" and "verified" read as the two
-     * separate statements they are. Absent on older tool output.
-     */
-    verification?: { errors: number; warnings: number };
-    /**
-     * ADR-0038 L1 — the individual findings behind the `verification` counts,
-     * surfaced under the chip so "N issues" expands into WHAT is wrong instead
-     * of being a dead-end badge.
-     */
-    issues?: Array<{ severity: 'error' | 'warning'; code: string; message: string; fix?: string }>;
-    /**
-     * Post-build "what's next" steps (apply_blueprint `nextSteps`). Rendered as
-     * a short getting-started checklist under the build summary.
-     */
-    nextSteps?: string[];
-  };
+  draftReview?: DraftReview;
   /**
    * ObjectStack extension. `propose_blueprint` returns a PLAN before anything
    * is staged (`status: 'blueprint_proposed'`). `mapMessages.ts` lifts the

packages/plugin-chatbot/src/mapMessages.ts

@@ -207,9 +207,25 @@ export interface DraftReview {
   items: Array<{ type: string; name: string }>;
   summary?: string;
   packageId?: string;
+  /**
+   * Backend lifecycle intent (from the tool result). `true` for whole-app
+   * builds (apply_blueprint) — eligible for the auto-publish "magic moment".
+   * Omitted for incremental edits, which stay drafts for explicit review.
+   */
   autoPublishable?: boolean;
+  /** Count of artifacts that failed in a partial build, surfaced not hidden. */
   failedCount?: number;
+  /**
+   * ADR-0045: the build was MATERIALIZED in-turn — real tables and seed
+   * rows exist; the app is live but `hidden` (unlisted). Preview should
+   * open the REAL app URL, not the draft overlay.
+   */
   materialized?: boolean;
+  /**
+   * ADR-0038 L1 graph-lint verdict for the staged build. Rendered as a
+   * verified/issues chip so "drafted" and "verified" read as the two
+   * separate statements they are. Absent on older tool output.
+   */
   verification?: { errors: number; warnings: number };
   /**
    * ADR-0038 L1 — the individual lint findings behind the `verification`
@@ -231,10 +247,11 @@ export interface DraftReview {
    * from the envelope's own `kind`: `apply_edit` answers `kind: 'edit'`, and a
    * whole-app `apply_blueprint` build carries no `kind`. An edit's `items` may
    * honestly include the `app` artifact it re-staged (an `add_object` op
-   * merges the nav), so every reader that asks "is this a whole-app build?"
-   * checks this before inferring a build from the staged artifact types.
-   * Only the value such a reader acts on is declared: an envelope that does
-   * not say `'edit'` lifts nothing here.
+   * merges the nav), so the readers that infer a whole-app build from a draft
+   * review's staged artifact types check this first: `buildProgressFromDraftReview`
+   * here, and app-shell's built-moment transition (`detectBuiltAppPackage` reads
+   * the envelope's own `kind` instead). Only the value those readers act on is
+   * declared: an envelope that does not say `'edit'` lifts nothing here.
    */
   kind?: 'edit';
 }