Skip to content

Commit f67bf85

Browse files
committed
fix(core,app-shell): the two runtime strings that cite an objectstack card name its repository
`RETIRED_ACTION_KEYS.execute` (the dev warning for an action that still carries the retired `execute` key) cited the card that retired the alias by a bare number, which in this repository resolves to an unrelated docs card. It now names objectstack-ai/objectstack#3855; the rest of the message is unchanged. The Studio skill form's `triggerConditions` help text gets the same treatment: objectstack-ai/objectstack#1878 and objectstack-ai/objectstack#1895. Changeset: patch for @object-ui/core and @object-ui/app-shell. Claude-Session: https://claude.ai/code/session_011p7ikEivgXefNDaE5S5Uec Co-authored-by: Claude <noreply@anthropic.com>
1 parent e327c89 commit f67bf85

3 files changed

Lines changed: 36 additions & 2 deletions

File tree

Lines changed: 34 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,34 @@
1+
---
2+
'@object-ui/core': patch
3+
'@object-ui/app-shell': patch
4+
---
5+
6+
Citations of objectstack cards now name their repository (objectui#11016).
7+
8+
A bare `#N` in this repository resolves to an objectui item. Where the sentence
9+
meant an objectstack card, a reader who followed the number landed on an
10+
unrelated objectui card or pull request, and nothing flagged it: both
11+
repositories answer for the number, so an earlier sweep that looked for dead
12+
numbers could not see this class.
13+
14+
Two of those citations are runtime text, and they now name the card they mean:
15+
16+
- `@object-ui/core`: the dev warning for an action that still carries the
17+
retired `execute` key (`RETIRED_ACTION_KEYS.execute`) points at
18+
objectstack-ai/objectstack#3855, the card that retired the alias. The rest of
19+
the message, including "rename the key to `target`", is unchanged.
20+
- `@object-ui/app-shell`: the Studio skill form's help text for
21+
`triggerConditions` points at objectstack-ai/objectstack#1878 and
22+
objectstack-ai/objectstack#1895.
23+
24+
The other sites are code comments and doc comments in the non-test sources,
25+
requalified the same way: a bare number whose sentence meant
26+
an objectstack card now reads `objectstack-ai/objectstack#N`. Numbers that mean
27+
an objectui card stay bare. Where a comment quotes objectstack's own text, the
28+
quote keeps its words and the card name sits in square brackets, the editorial
29+
mark for a substituted word.
30+
31+
Pending entries in this release that carry such a number get a dated note
32+
naming the card, and their frontmatter is unchanged.
33+
34+
Nothing else moves: no key, accept set, refusal decision or code path.

‎packages/app-shell/src/views/metadata-admin/default-schemas.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -174,7 +174,7 @@ const SCHEMAS: Record<string, Record<string, unknown>> = {
174174
triggerConditions: {
175175
type: 'array',
176176
title: 'Trigger Conditions',
177-
description: 'Programmatic activation conditions (context field / operator / value). The activation-critical field — previously only hand-editable (#1878/#1895).',
177+
description: 'Programmatic activation conditions (context field / operator / value). The activation-critical field — previously only hand-editable (objectstack-ai/objectstack#1878 / objectstack-ai/objectstack#1895).',
178178
items: {
179179
type: 'object',
180180
properties: {

‎packages/core/src/actions/actionKeys.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -368,7 +368,7 @@ export const HOST_DISPATCH_ACTION_KEYS = ['overrideNotice'] as const;
368368
* a tombstone the spec keeps only in order to reject it by name.
369369
*/
370370
export const RETIRED_ACTION_KEYS: Readonly<Record<string, string>> = {
371-
execute: '`execute` was removed in @objectstack/spec 17 (#3855) — rename the key to `target`. ' +
371+
execute: '`execute` was removed in @objectstack/spec 17 (objectstack-ai/objectstack#3855) — rename the key to `target`. ' +
372372
'The value (a script name or expression) is unchanged. ' +
373373
'Run `os migrate meta --from 16` to rewrite it automatically.',
374374
};

0 commit comments

Comments
 (0)