You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit b896749
Browse filesBrowse the repository at this point in the historyBrowse files
fix(app-shell): guard unsaved OWD overview rows in the Access rail and Studio header nav (#2600 follow-up) (#2610)
PackageOwdOverviewPanel tracked its unsaved per-object OWD rows internally
(rowState/dirtyCount) but reported them to no one, so both unsaved-edit
guards discarded them silently: the Access rail's confirm
(confirmDiscardMatrixEdits checked only matrixDirty) and the Studio
header's surface-level pillarDirty guard from PR #2606.
- PackageOwdOverviewPanel grows onDirtyChange — same contract as
PermissionMatrixEditPage (ref-stabilized transitions, false on unmount).
- AccessPillar folds it in as owdDirty alongside matrixDirty: the rail
confirm gates on the combined bit (the two surfaces never coexist), and
the combined bit mirrors up to the surface via an effect (replacing the
reportMatrixDirty wrapper).
- Re-clicking the open OWD rail entry is now a no-op (nothing remounts, so
no confirm), mirroring the set re-click.
- The create flow now lands on the new set's matrix even from the OWD
overview (setOwdOpen(false) in doCreate), so the up-front gate's discard
warning is truthful.
Co-authored-by: Jack Zhuang <277994282+os-zhuang@users.noreply.github.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
0 commit comments