Repository navigation
Commit ad39293
committed
docs(core): replace the dangling SECURITY_FIX_SUMMARY @see with its rationale
`SimpleExpressionEvaluator`'s doc block pointed at
https://github.com/objectstack-ai/objectui/blob/main/SECURITY_FIX_SUMMARY.md.
That file was deleted in ea72f18 — a 20-file bulk removal of the root-level
PR #300 / v0.4.0 summaries, 6742 deletions and zero insertions, so the content
was dropped outright rather than migrated. The link has 404'd since.
Reading `git show ea72f18^:SECURITY_FIX_SUMMARY.md` shows the doc block
already repeats most of what it carried (the operator list, the LIMITATIONS
list verbatim). One thing it carried is NOT in the doc block and is
load-bearing: the parser exists because CodeQL flagged the previous
`new Function(...contextKeys, "'use strict'; return (…)")` as "Unsafe code
constructed from library input". That makes the ban on dynamic code execution
a remediation constraint a future maintainer must not trade away for
expressiveness or speed, not a style preference. That sentence is now inline,
and the provenance points at the immutable git object instead of a `main` blob
path that no longer resolves.
Comment-only: `SimpleExpressionEvaluator` is not exported, so nothing changes
in the emitted `.d.ts`, and no behaviour, type or API surface moves.1 parent 79ebf30 commit ad39293
2 files changed
Lines changed: 20 additions & 2 deletions
File tree
- .changeset
- packages/core/src/validation/validators
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
Lines changed: 13 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
199 | 199 | | |
200 | 200 | | |
201 | 201 | | |
202 | | - | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
203 | 211 | | |
204 | 212 | | |
205 | 213 | | |
| |||
218 | 226 | | |
219 | 227 | | |
220 | 228 | | |
221 | | - | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
222 | 233 | | |
223 | 234 | | |
224 | 235 | | |
| |||
0 commit comments