Repository navigation
Commit 8ea3bee
fix(plugin-chatbot): localize the build-progress panel's own copy (objectui#7388) (#8888)
* fix(plugin-chatbot): localize the build-progress panel's own copy (objectui#7388)
Every label the build panel is HANDED was already localized: the console host
passes `openBuiltAppLabel`, `designBuiltAppLabel`, `previewDraftLabel` and the
three connection cues through its own `t()`. Every string the panel OWNED was
a literal in the component, so a fully Chinese conversation watched its app get
built under `Building your app…`, over `Objects` / `Views` / `Dashboards` /
`App` / `Sample data` row headings — one per row, on every build — and a
`+N more` overflow counter.
All of them now resolve through the console's pack as `chatbot.build.*`,
added to all ten locales. `BUILD_GROUP_LABEL`'s English `Record` becomes a
static `useBuildGroupLabel()` switch: a computed key would be invisible to
`check-i18n-call-site-keys`, and its `default` arm keeps the old `?? type`
behaviour verbatim, so an unknown artifact type still renders its raw type and
never a raw i18n key.
Known-phase rendering in English is unchanged, pinned in both worlds by
`buildPanelI18n-7388.test.tsx` plus the pre-existing provider-less pins in
`ChatbotEnhanced.test.tsx`.
Part of #7388 — the `verify` phase half is NOT here: nothing in the published
`@objectstack/spec@17.4.0` (nor anywhere in objectui) declares or emits a
`verify` phase on `data-build-progress`, so admitting one would build a
receiver with no producer.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01611D6ZaRaMmwTNQmSbk8MH
* fix(scripts): re-baseline the `i18n-locales` per-chunk ceiling onto both admitted claimants
`PER_CHUNK_GZIP_CEILINGS['i18n-locales']` 455,000 -> 465,000 and
`PER_CHUNK_BASELINE['i18n-locales']` 446,076 -> 456,196, moved together in one
commit as that file requires. The ten locale packs' citation of the retired
headroom is updated in the same change so it cannot go stale again: it now
names no figure at all, which is the form the file's own anti-drift rule allows.
Four console builds, one container, one instrument -- `i18n-locales` read out of
the `apps/console/dist/eager-closure.json` each build writes:
bbe285e main 454,602 (headroom 398)
3949cf3 main + objectui#8901 455,271 +669, over by 271
ea5eab7 main + objectui#8888 455,519 +917, over by 519
ba20b0bc0 main + BOTH 456,196 +1,594, over by 1,196
The two deltas sum to 1,586 against a measured 1,594: two independent claimants
on this chunk are additive to within 8 bytes, which is the fact a shared budget
needs and the one a per-pull-request reading cannot produce.
Sized at 8,804 bytes of headroom = 0.10x REGRESSION_THIS_GATE_MUST_CATCH_BYTES,
this key's own convention and marginally tighter than the 8,924 (0.10x) the
retired pair carried. NOT sized at the 804 bytes the overage needed: a line with
~0 headroom is what objectui#8816 was filed about -- it reddens whichever
in-flight pull request is weighed second and blames that diff for arithmetic
that is not its own.
Trimming was measured first and cannot reach 1,196 bytes inside these changes:
best key reuse is 128 bytes for objectui#8888 and there is no reuse candidate at
all for objectui#8901. The payload reduction that would make the next raise
unnecessary is real but is not this: `check:i18n-dead-keys` reports 127 confirmed
dead keys in ten packs, and `@object-ui/i18n` publishes them, so removing one is
a published-surface decision that needs its own card.
Nothing else moved: not REGRESSION_THIS_GATE_MUST_CATCH_BYTES, not the other
three per-chunk ceilings, not MAX_EAGER_CLOSURE_GZIP_BYTES (the aggregate holds
23,507 bytes of headroom, 0.26x, with both claimants on it).
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01611D6ZaRaMmwTNQmSbk8MH
---------
Co-authored-by: os-zhuang <support@objectstack.ai>
Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
Co-authored-by: os-zhuang <jack@objectstack.ai>1 parent fffa30d commit 8ea3bee
13 files changed
Lines changed: 389 additions & 11 deletions
File tree
- .changeset
- packages
- i18n/src/locales
- plugin-chatbot/src
- __tests__
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3011 | 3011 | | |
3012 | 3012 | | |
3013 | 3013 | | |
| 3014 | + | |
| 3015 | + | |
| 3016 | + | |
| 3017 | + | |
| 3018 | + | |
| 3019 | + | |
| 3020 | + | |
| 3021 | + | |
| 3022 | + | |
| 3023 | + | |
| 3024 | + | |
| 3025 | + | |
| 3026 | + | |
| 3027 | + | |
3014 | 3028 | | |
3015 | 3029 | | |
3016 | 3030 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3004 | 3004 | | |
3005 | 3005 | | |
3006 | 3006 | | |
| 3007 | + | |
| 3008 | + | |
| 3009 | + | |
| 3010 | + | |
| 3011 | + | |
| 3012 | + | |
| 3013 | + | |
| 3014 | + | |
| 3015 | + | |
| 3016 | + | |
| 3017 | + | |
| 3018 | + | |
| 3019 | + | |
| 3020 | + | |
3007 | 3021 | | |
3008 | 3022 | | |
3009 | 3023 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3343 | 3343 | | |
3344 | 3344 | | |
3345 | 3345 | | |
| 3346 | + | |
| 3347 | + | |
| 3348 | + | |
| 3349 | + | |
| 3350 | + | |
| 3351 | + | |
| 3352 | + | |
3346 | 3353 | | |
3347 | 3354 | | |
3348 | 3355 | | |
| |||
3413 | 3420 | | |
3414 | 3421 | | |
3415 | 3422 | | |
| 3423 | + | |
| 3424 | + | |
| 3425 | + | |
| 3426 | + | |
| 3427 | + | |
| 3428 | + | |
| 3429 | + | |
| 3430 | + | |
| 3431 | + | |
| 3432 | + | |
| 3433 | + | |
| 3434 | + | |
| 3435 | + | |
| 3436 | + | |
3416 | 3437 | | |
3417 | 3438 | | |
3418 | 3439 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3008 | 3008 | | |
3009 | 3009 | | |
3010 | 3010 | | |
| 3011 | + | |
| 3012 | + | |
| 3013 | + | |
| 3014 | + | |
| 3015 | + | |
| 3016 | + | |
| 3017 | + | |
| 3018 | + | |
| 3019 | + | |
| 3020 | + | |
| 3021 | + | |
| 3022 | + | |
| 3023 | + | |
| 3024 | + | |
3011 | 3025 | | |
3012 | 3026 | | |
3013 | 3027 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3006 | 3006 | | |
3007 | 3007 | | |
3008 | 3008 | | |
| 3009 | + | |
| 3010 | + | |
| 3011 | + | |
| 3012 | + | |
| 3013 | + | |
| 3014 | + | |
| 3015 | + | |
| 3016 | + | |
| 3017 | + | |
| 3018 | + | |
| 3019 | + | |
| 3020 | + | |
| 3021 | + | |
| 3022 | + | |
3009 | 3023 | | |
3010 | 3024 | | |
3011 | 3025 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3006 | 3006 | | |
3007 | 3007 | | |
3008 | 3008 | | |
| 3009 | + | |
| 3010 | + | |
| 3011 | + | |
| 3012 | + | |
| 3013 | + | |
| 3014 | + | |
| 3015 | + | |
| 3016 | + | |
| 3017 | + | |
| 3018 | + | |
| 3019 | + | |
| 3020 | + | |
| 3021 | + | |
| 3022 | + | |
3009 | 3023 | | |
3010 | 3024 | | |
3011 | 3025 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3003 | 3003 | | |
3004 | 3004 | | |
3005 | 3005 | | |
| 3006 | + | |
| 3007 | + | |
| 3008 | + | |
| 3009 | + | |
| 3010 | + | |
| 3011 | + | |
| 3012 | + | |
| 3013 | + | |
| 3014 | + | |
| 3015 | + | |
| 3016 | + | |
| 3017 | + | |
| 3018 | + | |
| 3019 | + | |
3006 | 3020 | | |
3007 | 3021 | | |
3008 | 3022 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3003 | 3003 | | |
3004 | 3004 | | |
3005 | 3005 | | |
| 3006 | + | |
| 3007 | + | |
| 3008 | + | |
| 3009 | + | |
| 3010 | + | |
| 3011 | + | |
| 3012 | + | |
| 3013 | + | |
| 3014 | + | |
| 3015 | + | |
| 3016 | + | |
| 3017 | + | |
| 3018 | + | |
| 3019 | + | |
3006 | 3020 | | |
3007 | 3021 | | |
3008 | 3022 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3017 | 3017 | | |
3018 | 3018 | | |
3019 | 3019 | | |
| 3020 | + | |
| 3021 | + | |
| 3022 | + | |
| 3023 | + | |
| 3024 | + | |
| 3025 | + | |
| 3026 | + | |
| 3027 | + | |
| 3028 | + | |
| 3029 | + | |
| 3030 | + | |
| 3031 | + | |
| 3032 | + | |
| 3033 | + | |
3020 | 3034 | | |
3021 | 3035 | | |
3022 | 3036 | | |
| |||
0 commit comments