You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 3702f92
Browse filesBrowse the repository at this point in the historyBrowse files
fix(ci): align the live-e2e backend pin with the lockfile, and pin the rule that says it must (#7970)
* fix(ci): align live-e2e backend pin with the lockfile and pin the rule
`e2e/live/ci/backend.env` pinned `OBJECTSTACK_VERSION=17.0.0-rc.2` while
`pnpm-lock.yaml` resolved `@objectstack/spec` 17.2.0. Both the file's own
header and `content/docs/guide/ci-cd-pipeline.md` state the two must match,
and that a mismatched pair "proves nothing" -- so for two minor versions the
`Live E2E (informational)` lane produced a green signal its own contract
declares meaningless.
Aligns the pair to the value the lockfile actually resolves (17.2.0, not the
`^17.0.0` range) and moves `OBJECTSTACK_REF` with it, to the commit the
`@objectstack/cli@17.2.0` release tag points at -- the pairing rule the file
header already states, and the one the previous pin honoured for rc.2.
Adds the missing comparison to `scripts/__tests__/ci-cd-pipeline-doc.test.ts`,
whose charter is pinning that page's claims to CI reality: it reads
`OBJECTSTACK_VERSION`, reads every `@objectstack/spec` version the lockfile
resolves (two independent readings, union must be one), and requires equality,
with both anti-vacuity floors the file's culture asks for.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013uAaxiwgYDybsTNV9xwa1M
* docs(e2e): name the live-lane backend pin by file, not by version literal
`e2e/live/saved-view-filter.spec.ts`'s header stated the measurement was taken
on `@objectstack/*@17.0.0-rc.2` -- the pair the previous commit just moved off.
It was the second reader of that literal on the fenced surfaces, and it went
stale the moment the pin did.
Names `OBJECTSTACK_VERSION` / `OBJECTSTACK_REF` in `e2e/live/ci/backend.env`
instead, and says the pair has moved since the measurement rather than implying
it has not. A comment that carries the value is a copy of the pin that nothing
updates; a comment that carries the file name cannot go stale behind it.
Comment only -- no assertion, import or code line is touched.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013uAaxiwgYDybsTNV9xwa1M
---------
Co-authored-by: Claude <noreply@anthropic.com>
0 commit comments