Skip to content

Commit 2e1b87c

Browse files
committed
fix(app-shell): move the #4575 German percent sample pin onto the locale convention (#4576)
`DatasetDefaultInspector`'s format-sample pin asserted the literal-suffix German form `12,3%`. The measure formatter now renders the locale's own percent convention, so the sample gained the no-break space before the sign, exactly as the two `dataset-format.locale.test.ts` pins did. Third and last authorized pin move for this card. The en sample in the case below it is unmoved, which is what says this is a convention change and not a numeral one. Caught by CI shard 3/4: my local sweep covered core / i18n / fields / plugin-dashboard / plugin-report but not app-shell, which is also a `formatMeasure` consumer. Re-swept the full consumption radius since: app-shell 394 files / 3,725 tests green, and plugin-gantt + plugin-grid + components 231 files / 2,064 tests green. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017Qqyix2QcnpUC9XeYVDzx3
1 parent 307b578 commit 2e1b87c

1 file changed

Lines changed: 9 additions & 1 deletion

File tree

‎packages/app-shell/src/views/metadata-admin/inspectors/DatasetDefaultInspector.measureLocale.test.tsx‎

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,15 @@ describe('dataset inspector format sample follows the display locale (objectui#4
127127
);
128128
// The decimal COMMA is the point: `12.3%` and `12,3%` read as different
129129
// numbers to the two audiences, not as the same one restyled.
130-
expect(sampleText()).toBe('12,3%');
130+
//
131+
// PIN MOVED (objectui#4576). The German expectation gained the no-break
132+
// space before the sign. `formatMeasure` appended a literal '%' in every
133+
// locale; it now renders the locale's own percent convention, the one a
134+
// list cell has used since #4553. The en sample in the case below is
135+
// UNMOVED, which is what says this was a convention change and not a
136+
// numeral one. Same class as the two moves in
137+
// `packages/core/src/utils/__tests__/dataset-format.locale.test.ts`.
138+
expect(sampleText()).toBe('12,3\u00a0%');
131139
});
132140

133141
it('keeps the en percent sample byte-identical (must-not-change)', () => {

0 commit comments

Comments
 (0)