Repository navigation
Commit f6ed5b8
committed
fix(objectql,cli): the recomputeUndefinedOnEmpty refusal answers INVALID_FIELD / 400 — the code every axis naming a field already takes (#15064)
Contract-review patch round on PR #15708 (verdict 5550099353), items 1, 3, 4.
- `resolveRecomputeScope` stamps `code = 'INVALID_FIELD'`, `status = 400`
and `field = unresolved[0]` beside `fields`, the shape of the engine's
sibling producers (`assertProjectionHasNoDottedPaths`,
`undeclaredWriteFieldErrors`). `FIELD_NOT_FOUND` / 404 had no producer in
this repo; handing a never-emitted 404 its first producer for a condition
the catalog already assigns to a 400 is the two-codes-one-condition drift
ADR-0112 exists to prevent — and two of the refused shapes name a field
that exists (a real non-summary field; a roll-up on an object `objects`
left out), so this is an option value that could not be applied, not an
addressed resource that was not found.
- Pins retargeted: `summary-backfill.test.ts` "REFUSES a name it cannot
resolve" (six code/status assertions, now also `field`/`fields`) and
`summary-nulls.test.ts` "a refused scope entry … reaches the --json error
envelope" (`code`).
- `content/docs/api/error-catalog.mdx`: the `INVALID_FIELD` Cause gains the
`recomputeUndefinedOnEmpty` / `--recompute-undefined-on-empty` axis; the
`FIELD_NOT_FOUND` entry is untouched.
- `SummaryBackfillReport.nullRows` TSDoc counts the named min/max/avg holes.
- Option TSDoc, resolver docblock and the changeset paragraph updated
wherever FIELD_NOT_FOUND / 404 was named.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01ARYe3yQTQCUFm5qPYNgKaJ1 parent 7c96f73 commit f6ed5b8
5 files changed
Lines changed: 46 additions & 19 deletions
File tree
- .changeset
- content/docs/api
- packages
- cli/src/commands/migrate
- objectql/src
Lines changed: 4 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
33 | | - | |
34 | | - | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
35 | 37 | | |
36 | 38 | | |
37 | 39 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
75 | 75 | | |
76 | 76 | | |
77 | 77 | | |
78 | | - | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
79 | 84 | | |
80 | 85 | | |
81 | 86 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
129 | 129 | | |
130 | 130 | | |
131 | 131 | | |
132 | | - | |
| 132 | + | |
133 | 133 | | |
134 | | - | |
| 134 | + | |
135 | 135 | | |
136 | 136 | | |
137 | 137 | | |
| |||
144 | 144 | | |
145 | 145 | | |
146 | 146 | | |
147 | | - | |
| 147 | + | |
148 | 148 | | |
149 | 149 | | |
150 | 150 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
534 | 534 | | |
535 | 535 | | |
536 | 536 | | |
537 | | - | |
| 537 | + | |
538 | 538 | | |
539 | 539 | | |
540 | 540 | | |
| |||
548 | 548 | | |
549 | 549 | | |
550 | 550 | | |
551 | | - | |
552 | | - | |
| 551 | + | |
| 552 | + | |
| 553 | + | |
| 554 | + | |
| 555 | + | |
| 556 | + | |
553 | 557 | | |
554 | 558 | | |
555 | 559 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
128 | 128 | | |
129 | 129 | | |
130 | 130 | | |
131 | | - | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
132 | 135 | | |
133 | 136 | | |
134 | 137 | | |
| |||
186 | 189 | | |
187 | 190 | | |
188 | 191 | | |
189 | | - | |
190 | | - | |
191 | | - | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
192 | 196 | | |
193 | 197 | | |
194 | 198 | | |
| |||
252 | 256 | | |
253 | 257 | | |
254 | 258 | | |
255 | | - | |
256 | | - | |
257 | | - | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
258 | 273 | | |
259 | 274 | | |
260 | 275 | | |
| |||
278 | 293 | | |
279 | 294 | | |
280 | 295 | | |
281 | | - | |
282 | | - | |
283 | | - | |
| 296 | + | |
| 297 | + | |
| 298 | + | |
| 299 | + | |
284 | 300 | | |
285 | 301 | | |
286 | 302 | | |
| |||
0 commit comments