Skip to content

Commit d18f7d7

Browse files
committed
fix(spec): attribute the cloud registration reading to its filer
The list's header already says this half of the contract cannot be conformance-tested from this repository. The pin comment and the changeset stated the cloud registration chain as though this change had re-taken it; they now name it as a reading carried on the filer's name, at the cloud ref it was taken against, and say plainly that only the objectstack half is asserted here. Claude-Session: https://claude.ai/code/session_01JbZnqu8bt6YqfJsr9vaFb3 Co-authored-by: Claude <noreply@anthropic.com>
1 parent d34a69f commit d18f7d7

2 files changed

Lines changed: 17 additions & 10 deletions

File tree

‎.changeset/spec-cloud-provided-environment-credential.md‎

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,15 @@ an action parameter `reference`, a field `reference`, a dashboard
1515
`objects.<name>` subtree naming `sys_environment_credential` all stop being
1616
diagnosed.
1717

18-
Why this name: `@objectstack/service-tenant` registers it in the cloud
19-
repository on exactly the path the list's existing `sys_package`,
20-
`sys_package_version` and `sys_package_installation` members take —
21-
`objects/sys-environment-credential.object.ts` exported through
18+
Why this name: as read in the cloud repository at `cb8ee7ff60`,
19+
`@objectstack/service-tenant` registers it on exactly the path the list's
20+
existing `sys_package`, `sys_package_version` and `sys_package_installation`
21+
members take — `objects/sys-environment-credential.object.ts` exported through
2222
`objects/index.ts`, listed in `tenantObjects`, spread into
23-
`manifestService.register({ objects })` by `tenant-plugin.ts`.
23+
`manifestService.register({ objects })` by `tenant-plugin.ts`. That reading is
24+
the cloud repository's and is carried here on its filer's name; per this list's
25+
header it cannot be conformance-tested from this repo, and this change does not
26+
claim to have re-taken it.
2427

2528
Unlike the earlier additions, this one fixes no diagnostic that fires today: no
2629
`*.object.ts` in this repository references the name, so nothing shipped was

‎packages/spec/src/system/constants/platform-object-names.test.ts‎

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -186,8 +186,12 @@ describe('platform-object predicates', () => {
186186
});
187187

188188
it('resolves the tenant credential store the cloud runtime registers', () => {
189-
// `sys_environment_credential` is registered by `@objectstack/service-tenant`
190-
// on the same path as the `sys_package*` family above: declared in
189+
// The cloud-side registration is a READING TAKEN IN THE CLOUD REPOSITORY,
190+
// at `cb8ee7ff60`, and carried here on its filer's name — like every other
191+
// member of this list, it is not re-checkable from this repo, which is what
192+
// the list's own header means by "they cannot be conformance-tested from
193+
// this repo". As read there, `@objectstack/service-tenant` registers the
194+
// name on the same path as the `sys_package*` family above: declared in
191195
// `objects/sys-environment-credential.object.ts`, exported through
192196
// `objects/index.ts`, listed in `tenantObjects` in `manifest.ts`, and spread
193197
// into `manifestService.register({ objects })` by `tenant-plugin.ts`.
@@ -202,9 +206,9 @@ describe('platform-object predicates', () => {
202206
// So the first author to write the reference would have been told it looked
203207
// like a typo. Pinned by name, beside `sys_license` and the package family,
204208
// for the same reason: dropping it fails one readable assertion instead of
205-
// nothing. The other half of the contract — that the cloud runtime really
206-
// registers the table — is owned by the cloud repository per the list's
207-
// header, and is not asserted here.
209+
// nothing. What this test asserts is the objectstack half alone — that the
210+
// list carries the name and the predicate resolves it. The cloud half is
211+
// owned by the cloud repository and is not asserted here.
208212
expect(isPlatformProvidedObjectName('sys_environment_credential')).toBe(true);
209213
expect(CLOUD_PROVIDED_OBJECT_NAMES).toContain('sys_environment_credential');
210214
});

0 commit comments

Comments
 (0)