Skip to content

Commit d06b457

Browse files
os-warrenclaude
andcommitted
chore(tooling): drop this card's six entries from KNOWN_TEARDOWN_UNREACHED
`scripts/check-plugin-teardown-shape.mjs` (#10619) landed on main after this branch was cut. Its baseline is shrink-only and a stale entry is itself a failure, so the six plugins repaired here would have reddened the gate on main the moment this merged — the merge queue would more likely have evicted this PR first, rebuilding the queue for everyone behind it. That is the #9371 blast-radius shape, on a PR whose subject is #9371's defect class. Which six was taken from the gate's own failure output, not from line numbers: run before the edit, it named exactly these six as `no longer unreached`, and each was independently confirmed to declare a real `destroy()` in this tree. The other five entries are untouched. `MetadataPlugin`, `AppPlugin` and `ExternalValidationPlugin` spell the alias as an arrow property and `EmailServicePlugin` / `WebhookOutboxPlugin` spell it `dispose`; none has a `destroy()` yet, and they are #10772's card. Deleting them would be a false declaration that they are fixed. Held count after this change is 5, measured, not predicted. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PnJHU45vPJj5UQrxe946Bx
1 parent 7c3c536 commit d06b457

1 file changed

Lines changed: 0 additions & 6 deletions

File tree

‎scripts/check-plugin-teardown-shape.mjs‎

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -233,17 +233,11 @@ const POSITIVE_CONTROL = {
233233
* `EmailServicePlugin` / `WebhookOutboxPlugin` spell it `dispose`.
234234
*/
235235
const KNOWN_TEARDOWN_UNREACHED = [
236-
{ file: 'packages/connectors/connector-openapi/src/connector-openapi-plugin.ts', cls: 'ConnectorOpenApiPlugin', alias: 'stop', repair: '#10371' },
237-
{ file: 'packages/connectors/connector-rest/src/connector-rest-plugin.ts', cls: 'ConnectorRestPlugin', alias: 'stop', repair: '#10371' },
238-
{ file: 'packages/connectors/connector-slack/src/connector-slack-plugin.ts', cls: 'ConnectorSlackPlugin', alias: 'stop', repair: '#10371' },
239236
{ file: 'packages/metadata/src/plugin.ts', cls: 'MetadataPlugin', alias: 'stop', repair: '#10371' },
240-
{ file: 'packages/plugins/plugin-approvals/src/approvals-plugin.ts', cls: 'ApprovalsServicePlugin', alias: 'stop', repair: '#10371' },
241237
{ file: 'packages/plugins/plugin-email/src/email-plugin.ts', cls: 'EmailServicePlugin', alias: 'dispose', repair: '#10371' },
242-
{ file: 'packages/plugins/plugin-reports/src/reports-plugin.ts', cls: 'ReportsServicePlugin', alias: 'stop', repair: '#10371' },
243238
{ file: 'packages/plugins/plugin-webhooks/src/webhook-outbox-plugin.ts', cls: 'WebhookOutboxPlugin', alias: 'dispose', repair: '#10371' },
244239
{ file: 'packages/runtime/src/app-plugin.ts', cls: 'AppPlugin', alias: 'stop', repair: '#10371' },
245240
{ file: 'packages/runtime/src/external-validation-plugin.ts', cls: 'ExternalValidationPlugin', alias: 'stop', repair: '#10371' },
246-
{ file: 'packages/services/service-knowledge/src/knowledge-service-plugin.ts', cls: 'KnowledgeServicePlugin', alias: 'stop', repair: '#10371' },
247241
];
248242

249243
// ---------------------------------------------------------------------------

0 commit comments

Comments
 (0)