Repository navigation
Commit b169f21
committed
test(plugin-email): pin the queue-delivery fake engine's delete() to ObjectQL's own dispatch (#4550)
`check:engine-double-contract` flagged the fake engine in
email-plugin.queue-delivery.test.ts: its `delete()` hand-mirrored the engine's
guard (`if (opts?.where?.id == null) throw`) instead of routing through
`assertEngineDeleteDispatch`. That mirror is looser than the engine on exactly
the case a copy always drops — `where: { id: { $in: [...] } }` reads as an id
and is a multi-row predicate, which the real engine rejects without `multi`.
Routes through the producer's own predicate, same shape as the other 13 pinned
doubles, and adds the `@objectstack/objectql` devDependency the import needs
(the precedent in plugin-approvals / plugin-sharing).
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017MCKJaEomEqg4tvz4SzdNd1 parent e09ee47 commit b169f21
3 files changed
Lines changed: 19 additions & 4 deletions
File tree
- packages/plugins/plugin-email
- src
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
| 28 | + | |
28 | 29 | | |
29 | 30 | | |
30 | 31 | | |
| |||
Lines changed: 15 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
| 15 | + | |
15 | 16 | | |
16 | 17 | | |
17 | 18 | | |
| |||
82 | 83 | | |
83 | 84 | | |
84 | 85 | | |
85 | | - | |
86 | | - | |
87 | | - | |
88 | | - | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
89 | 100 | | |
90 | 101 | | |
91 | 102 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
0 commit comments