Repository navigation
Commit aa3e6d4
committed
fix(spec,lint): correct a false clause in the ledger README and narrow a test's claim
Two required fixes from the at-tier contract review of this PR, both re-measured
here before editing rather than taken from the record.
F1 — `packages/spec/liveness/README.md`'s `field` cell claimed this was the
type's FIRST `planned` -> `live` flip. False: `field.valueDomain` reads `live`
with `verifiedAt` 2026-09-04 on origin/main, and `fa125f3bfe` (#15316) is the
commit that changed its `"status": "planned"` to `"status": "live"` in this very
file. Corrected in place, and the correction says what was wrong: a file whose
job is to say true things about the ledger had acquired a confident false
sentence of exactly the species it exists to catch.
F2 — the anti-vacuity guard's comment and test name claimed "same ledger load,
one warning and not two" / "not a lint that stopped loading ledgers". Measured,
that overstates it: `loadWarnMap` returns an empty map silently for a missing
(:77) or unparseable (:81-83) `field.json`, and `object` and `field` are two
separate loads (:485-486), so the guard distinguishes a lint that never resolved
the ledger DIRECTORY, not one that lost the field ledger. The name and comment
are narrowed to that; the pins themselves are unchanged and still fail when the
row is reverted. The per-file blind spot is `loadWarnMap`'s and is left to its
own card.
Claude-Session: https://claude.ai/code/session_01JbZnqu8bt6YqfJsr9vaFb3
Co-authored-by: Claude <noreply@anthropic.com>1 parent 7f9df93 commit aa3e6d4
2 files changed
Lines changed: 23 additions & 10 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
727 | 727 | | |
728 | 728 | | |
729 | 729 | | |
730 | | - | |
731 | | - | |
732 | | - | |
733 | | - | |
734 | | - | |
735 | | - | |
736 | | - | |
737 | | - | |
738 | | - | |
| 730 | + | |
| 731 | + | |
| 732 | + | |
| 733 | + | |
| 734 | + | |
| 735 | + | |
| 736 | + | |
| 737 | + | |
| 738 | + | |
| 739 | + | |
| 740 | + | |
| 741 | + | |
| 742 | + | |
| 743 | + | |
| 744 | + | |
| 745 | + | |
| 746 | + | |
| 747 | + | |
| 748 | + | |
| 749 | + | |
| 750 | + | |
| 751 | + | |
739 | 752 | | |
740 | 753 | | |
741 | 754 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
902 | 902 | | |
903 | 903 | | |
904 | 904 | | |
905 | | - | |
| 905 | + | |
906 | 906 | | |
907 | 907 | | |
908 | 908 | | |
| |||
0 commit comments