Skip to content

Commit a768f81

Browse files
os-helpclaude
andauthored
fix(cli): lower TEST_DEBT['@objectstack/rest'] to 155 and fix stale note (#7248)
pnpm check:type-check-debt --re-measure showed the entry (163) sitting 12 above the actual tsc count (151 at dispatch time; 155 re-verified on this merge base, 55da611), a surplus that could absorb regressions silently since #6905 graduated the package's src half to a real compiler gate but left this TEST_DEBT entry as the sole guard on its test layer (#6939). The note also still read "Also in DEBT." after #6905 removed the package's DEBT entry -- a residual pointer to a ledger row that no longer exists (#7038). Rewrote it to "Graduated from DEBT in #6905." and updated the composition/bootstrap-margin prose so it describes the new exact-measurement state (no more +10 margin) instead of a stale reading of 163. --lower is not scoped to a single package, so it also touched 11 unrelated DEBT/TEST_DEBT entries across other packages; those were reverted to keep this PR to the @objectstack/rest entry only, per this card's scope. Fixes #6939 Fixes #7038 Claude-Session: https://claude.ai/code/session_0158ZQo7LiHSxGWpYKuPq1wu Co-authored-by: Claude <noreply@anthropic.com>
1 parent 7084313 commit a768f81

1 file changed

Lines changed: 15 additions & 6 deletions

File tree

‎scripts/check-type-check-coverage.mjs‎

Lines changed: 15 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -503,12 +503,16 @@ const TEST_DEBT = {
503503
+ '`GET /meta/:type/:name` envelope convergence). Nothing else in the package moved.',
504504
},
505505
'@objectstack/rest': {
506-
errors: 163,
507-
note: 'TS2835 x67 (NodeNext extensions), TS7006 x57, TS2554 x13, TS2550 x10. Also in DEBT. Measured '
506+
errors: 155,
507+
note: 'TS2835 x67 (NodeNext extensions), TS7006 x57, TS2554 x13, TS2550 x10 (composition as counted at '
508+
+ '153; not re-tallied by class at the 155 below). Graduated from DEBT in #6905 -- this TEST_DEBT '
509+
+ 'entry is now the sole gate on the package\'s test layer (src moved to `turbo run typecheck`). '
510+
+ 'Measured '
508511
+ '105 -> 136 (5ab08428) -> 143 (77adf29, hours later the same day) -> 153 (e8db1a230). Read the '
509512
+ 'top-of-ledger NodeNext note before sizing this one: TS2835 and the implicit-any pile it causes '
510513
+ 'are 124 of the 153, and '
511-
+ 'they are one repair, not 124. Of the latest +10, 8 are attributable to three test files this '
514+
+ 'they are one repair, not 124. Of the +10 that then bumped 153 to a bootstrap-margin RECORDED 163, '
515+
+ '8 are attributable to three test files that '
512516
+ 'window added -- rest-meta-save-receipt-envelope.test.ts x4 (#5265 / PR #5926), '
513517
+ 'meta-item-envelope.test.ts x2 (#5563 / PR #5895), '
514518
+ 'analytics-dataset-unlisted-refusal-envelope.test.ts x2; the remaining 2 landed in files that '
@@ -517,9 +521,14 @@ const TEST_DEBT = {
517521
+ 'fastest-moving entry in either ledger, and it is '
518522
+ 'the one that proved the gate works: #5278\'s own PR went red in CI on it, because a `pull_request` '
519523
+ 'run builds the branch MERGED INTO main and three rest-touching PRs had landed since the sweep. A '
520-
+ 'ledger number is always a number about a moment. RECORDED 163 is a bootstrap margin (+10 over 153 '
521-
+ 'measured at e8db1a230 and re-confirmed at 153 an hour later at 77c7c884b) -- tighten via the ℹ '
522-
+ 'hint immediately after landing (#5278 option A).',
524+
+ 'ledger number is always a number about a moment. RECORDED 163 stood as that bootstrap margin (+10 '
525+
+ 'over 153 measured at e8db1a230 and re-confirmed at 153 an hour later at 77c7c884b) until #6939 '
526+
+ '(a surplus finding filed right after the #6905 DEBT graduation) re-measured tsc at 155 -- an 8-error '
527+
+ 'surplus the margin had been silently absorbing, and #7038 caught the note\'s "Also in DEBT." sentence '
528+
+ 'going stale in the same graduation. Lowered 163 -> 155 at 55da611 (#6939, #7038): RECORDED now '
529+
+ 'equals the exact measurement, no margin, so the next new error here goes red immediately -- a '
530+
+ 'bootstrap margin can be re-established deliberately later if that slack is wanted again '
531+
+ '(#5278 option A).',
523532
},
524533
'@objectstack/plugin-auth': {
525534
errors: 131,

0 commit comments

Comments
 (0)