Repository navigation
Commit 9051802
Maintainer ruling of 2026-08-11 on #7378, option (a): the `name` argument is
the effective storage key and `data.name` never overrides it. Written into the
contract TSDoc on `register` / `get`, and `MetadataFacade` aligned to it.
Two of the three measured divergence cells are settled:
- the effective key — `MetadataFacade.register` derived its key from the
document (`data.name ?? name`, and `data.id` for the generic store), so a
document whose own name disagreed with the argument was filed under the
document's spelling and `get`/`exists` missed it. It now keys on the
argument, reconciling the document to it.
- the dropped non-object `data` — a primitive was accepted with no throw and
filed under the literal key `undefined`, readable back through no member. It
is now boxed as `{ name, content }`, the shape this class's own reads already
unwrap. Arrays are boxed too rather than spread into `{ 0: …, 1: … }`.
The third cell (the plural `objects` alias) is NOT changed: the alias that
decides it is `SchemaRegistry.getItem`/`listItems`' own read-side special-case,
and both routes to aligning it are worse than the divergence — narrowing the
facade's write side re-opens #6725 for the plural spelling, and removing the
registry alias runs against the platform's enforced plural→singular direction
(`canonicalMetaType` #4432, `RestServer.metaTypeSingular`,
`check:meta-type-normalized`). Its pin survives with that measurement written
out, and the question is escalated on #7378.
The conformance pins for the ruled rows now assert the ruled behaviour rather
than the old `absent` divergence, plus a new `array-data-roundtrips` case and a
universal assertion that a document's own name never becomes a second key.
Option (c), loud refusal on a disagreement, is recorded as the v18 strictness
candidate and deliberately not implemented.
Claude-Session: https://claude.ai/code/session_01KtffEdkV9BA8f4yQXGXP9E
Co-authored-by: Claude <noreply@anthropic.com>
1 parent 1530870 commit 9051802
5 files changed
Lines changed: 340 additions & 72 deletions
File tree
- .changeset
- packages
- objectql/src
- spec/src/contracts
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
24 | 69 | | |
25 | 70 | | |
26 | 71 | | |
| |||
39 | 84 | | |
40 | 85 | | |
41 | 86 | | |
42 | | - | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
43 | 93 | | |
44 | 94 | | |
45 | | - | |
46 | | - | |
47 | | - | |
| 95 | + | |
48 | 96 | | |
49 | 97 | | |
50 | 98 | | |
| |||
54 | 102 | | |
55 | 103 | | |
56 | 104 | | |
57 | | - | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
58 | 111 | | |
59 | 112 | | |
60 | 113 | | |
| |||
0 commit comments