Repository navigation
Commit 8fd246d
docs(spec): name the shape the transports carry in the websocket retirement note (#16978)
* docs(spec): name the shape the transports carry in the websocket retirement note
The retirement note for the deleted `FilterOperator` / `EventFilterCondition` /
`EventFilterSchema` vocabulary said the subscription shape the transports
actually carry is the `filters: z.unknown()` on `SubscriptionEventSchema`
(`api/realtime.zod.ts`). Measured, no transport parses that schema at all: the
shipped subscription path carries a plain TS interface one directory over,
`contracts/realtime-service.ts#RealtimeSubscriptionOptions`, whose `object` and
`eventTypes` are the only two fields `matchesSubscription` reads.
Only the sentence's second half moves. Its first half — `matchesSubscription`
matches on object name and event type only — was already exact.
`SubscriptionEventSchema.filters` keeps its place in the note as the sibling
declaration of the same unenforced kind, which is what it is; it is simply no
longer described as a shape anything transports. The correction uses a symbol
anchor rather than a bare name, because the whole point of the sentence is which
of four same-ish spellings is meant, and rather than a line number, because
prose citations by line rot.
No key, type, export or tombstone is touched, and no behaviour changes.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016N6xmWt5hYm94ffVEwGH8x
* chore(changeset): patch @objectstack/spec for the websocket retirement-note correction
Both halves of the publish test say yes, so this is not a `skip-changeset`: the
changed path matches `src/**/*.zod.ts` in the package's `files[]`, and the
changed text is byte-present in the packed tarball. Measured on the real
`npm pack` output with controls — a `.describe()` from the same file reaches
`src` + `dist` + `json-schema` (7 files), a string unique to a sibling
`*.test.ts` reaches none, and this `//` comment reaches exactly the shipped
source file. `src/**/*.zod.ts` is the tree that decides it.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016N6xmWt5hYm94ffVEwGH8x
---------
Co-authored-by: Claude <noreply@anthropic.com>1 parent eda26ce commit 8fd246d
2 files changed
Lines changed: 21 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
61 | 61 | | |
62 | 62 | | |
63 | 63 | | |
64 | | - | |
65 | | - | |
66 | | - | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
67 | 70 | | |
68 | 71 | | |
69 | 72 | | |
| |||
0 commit comments