Repository navigation
Commit 8ec0646
committed
test(rest): clear two CI ratchets the new OWD gate suite tripped (#7674)
Both are ratchets on the new integration test's own surface, not on the fix.
Neither is remedied by raising a number, and neither was raised.
1. `query-options-erasure` — the test surface grew 242 -> 243. The new site was
`engine.find('sys_metadata', { … } as any)` in the suite's persistence probe.
The input is not off-contract, so the remedy is the first one the rule's
message prescribes: drop the assertion and let it infer against
`EngineQueryOptions`, keeping `tsc` as the enforcing channel for those keys
(#4674). No `as unknown as EngineQueryOptions` escape is warranted here, and
the baseline is unchanged — measured back at 242, the ceiling.
2. `TypeScript Type Check` TEST_DEBT — `@objectstack/rest` measured 159 against
a recorded 155, which since #6939 carries no margin. All four were in the new
file: one TS2835 (a relative import without its `.js` extension — the trap
AGENTS.md names, and the class that is already 124 of this entry's debt) and
three TS2554 from hand-rolled `registerObject` calls missing the required
`packageId`. The import gains its extension; the three platform-object
registrations move onto `registerApp` under
`com.objectstack.metadata-objects`, which is the seam
`assembleMetadataProtocol` itself uses — so the harness got more faithful
rather than merely quieter. Re-measured at exactly 155; the ledger is
untouched and no other entry was lowered.
Neither ratchet is evaluated by a package's own `test`/`typecheck` scripts —
rest's tsconfig excludes its own tests while the TEST_DEBT ratchet measures raw
`tsc --noEmit` including them — which is why a green local run said nothing
about either.1 parent b82488c commit 8ec0646
1 file changed
Lines changed: 28 additions & 9 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
73 | 73 | | |
74 | 74 | | |
75 | 75 | | |
76 | | - | |
| 76 | + | |
77 | 77 | | |
78 | 78 | | |
79 | 79 | | |
| |||
184 | 184 | | |
185 | 185 | | |
186 | 186 | | |
187 | | - | |
188 | | - | |
189 | | - | |
190 | | - | |
191 | | - | |
192 | | - | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
193 | 202 | | |
194 | 203 | | |
195 | 204 | | |
| |||
228 | 237 | | |
229 | 238 | | |
230 | 239 | | |
231 | | - | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
| 246 | + | |
| 247 | + | |
| 248 | + | |
| 249 | + | |
| 250 | + | |
232 | 251 | | |
233 | | - | |
| 252 | + | |
234 | 253 | | |
235 | 254 | | |
236 | 255 | | |
| |||
0 commit comments