Skip to content

Commit 8315ac6

Browse files
committed
test(spec): the pin / reorder PUT parse output keeps the declared round-trip keys
Claude-Session: https://claude.ai/code/session_01ARcDurZ5j34RdqsGgc4jgH Co-authored-by: Claude <noreply@anthropic.com>
1 parent 3ee095b commit 8315ac6

2 files changed

Lines changed: 7 additions & 4 deletions

File tree

‎packages/spec/src/ui/view-metadata-schema.test.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -415,7 +415,7 @@ describe('ViewMetadataSchema — genuine validation across the three runtime sha
415415
name: 'showcase_task.default',
416416
object: 'showcase_task',
417417
viewKind: 'list',
418-
_isOverride: true, // objectui's private marker — undeclared, rides `.strip()` as before
418+
_isOverride: true, // objectui's settings-overlay marker — declared on this member since #20456
419419
columnState: { order: ['email', 'name'], widths: { email: 240 } },
420420
});
421421
expect(r.success).toBe(true);

‎packages/spec/src/ui/view-union-diagnostics.test.ts‎

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -300,9 +300,12 @@ describe('[#7025] the acceptance face of ViewMetadataSchema — as re-ruled by #
300300
// so it parses to a list (`type: 'grid'`). It used to parse to
301301
// `type: 'simple'` — a FORM — because the form member was the one accepting
302302
// it, with every list key stripped unread.
303-
['put.isPinned', { isPinned: true, ...BOUND_LIST }, { type: 'grid', ...BOUND_LIST }],
304-
['put.sortOrder', { sortOrder: 3, ...BOUND_LIST }, { type: 'grid', ...BOUND_LIST }],
305-
['put.pinAndOrder', { isPinned: true, sortOrder: 3, ...BOUND_LIST }, { type: 'grid', ...BOUND_LIST }],
303+
// [#20456] …and the pin / reorder keys it carries are the console's
304+
// round-trip keys, declared on this member now, so the parse KEEPS them.
305+
// They used to be `.strip()`ped from the output while the save stored them.
306+
['put.isPinned', { isPinned: true, ...BOUND_LIST }, { type: 'grid', isPinned: true, ...BOUND_LIST }],
307+
['put.sortOrder', { sortOrder: 3, ...BOUND_LIST }, { type: 'grid', sortOrder: 3, ...BOUND_LIST }],
308+
['put.pinAndOrder', { isPinned: true, sortOrder: 3, ...BOUND_LIST }, { type: 'grid', isPinned: true, sortOrder: 3, ...BOUND_LIST }],
306309
];
307310

308311
const REFUSED: Array<[string, unknown, string[]]> = [

0 commit comments

Comments
 (0)